Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce some logging #1451

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Reduce some logging #1451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...ems.zigbee.dongle.ember/src/main/java/com/zsmartsystems/zigbee/dongle/ember/EmberNcp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ public EzspVersionResponse getVersion() {
logger.debug("No response from ezspVersion command");
return null;
}
logger.debug(response.toString());
lastStatus = null;

return response;
Expand Down Expand Up @@ -528,7 +527,7 @@ public EzspStatus setConfiguration(EzspConfigId configId, Integer value) {
EzspSetConfigurationValueRequest request = new EzspSetConfigurationValueRequest();
request.setConfigId(configId);
request.setValue(value);
logger.debug(request.toString());
logger.trace(request.toString());

EzspTransaction transaction = protocolHandler.sendEzspTransaction(
new EzspSingleResponseTransaction(request, EzspSetConfigurationValueResponse.class));
Expand Down
4 changes: 2 additions & 2 deletions ...ber/src/main/java/com/zsmartsystems/zigbee/dongle/ember/internal/ash/AshFrameHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ public void run() {
responseFrame = new AshFrameNak(ackNum);
}
} else {
logger.debug("<-- RX ASH frame: {}", packet);
logger.trace("<-- RX ASH frame: {}", packet);

// Reset the exception counter
exceptionCnt = 0;
Expand Down Expand Up @@ -568,7 +568,7 @@ private void sendRetry() {
// Synchronize this method to ensure a packet gets sent as a block
private synchronized void outputFrame(AshFrame ashFrame) {
ashFrame.setAckNum(ackNum);
logger.debug("--> TX ASH frame: {}", ashFrame);
logger.trace("--> TX ASH frame: {}", ashFrame);

// Send the data
int[] outputBuffer = ashFrame.getOutputBuffer();
Expand Down
10 changes: 5 additions & 5 deletions ...s.zigbee/src/main/java/com/zsmartsystems/zigbee/transaction/ZigBeeTransactionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ private void send(ZigBeeTransaction transaction) {
if (transaction.getTransactionId() == null) {
transaction.setTransactionId(transactionIdCounter.getAndIncrement() & 0xff);
}
logger.debug("{}: Sending {}", transaction.getIeeeAddress(), transaction);
logger.trace("{}: Sending {}", transaction.getIeeeAddress(), transaction);
addTransactionListener(transaction);
networkManager.sendCommand(transaction.startTransaction());
}
Expand Down Expand Up @@ -520,7 +520,7 @@ protected ScheduledFuture<?> scheduleTask(Runnable runnableTask, long delay) {
* @param state the {@link TransactionState} of the transaction on completion
*/
protected void transactionComplete(ZigBeeTransaction transaction, TransactionState state) {
logger.debug("Transaction complete: {}", transaction);
logger.trace("Transaction complete: {}", transaction);
removeTransactionListener(transaction);

if (isShutdown) {
Expand Down Expand Up @@ -555,7 +555,7 @@ protected void transactionComplete(ZigBeeTransaction transaction, TransactionSta
* @param command the {@link ZigBeeCommand} to send to the transactions
*/
private void notifyTransactionCommand(final ZigBeeCommand command) {
logger.debug("notifyTransactionCommand: {} ", command);
logger.trace("notifyTransactionCommand: {} ", command);
synchronized (outstandingTransactions) {
// Notify the listeners
for (final ZigBeeTransaction transaction : outstandingTransactions) {
Expand Down Expand Up @@ -615,7 +615,7 @@ public void removeNode(IeeeAddress address) {
}
queue.shutdown();

logger.debug("{}: Removing queue from transaction manager", address);
logger.trace("{}: Removing queue from transaction manager", address);

// Remove any outstanding transactions from this queue that have already been sent
synchronized (outstandingTransactions) {
Expand All @@ -639,7 +639,7 @@ public void removeNode(IeeeAddress address) {
*/
private void sendNextTransaction() {
synchronized (this) {
logger.debug(
logger.trace(
"Transaction Manager: Send Next transaction. outstandingTransactions={}, outstandingQueues={}, sleepy={}/{}",
outstandingTransactions.size(), outstandingQueues.size(), sleepyTransactions,
maxSleepyTransactions);
Expand Down
Loading