docker: Experimentally enable local arm64 or multiarch image builds. #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow building amd64+arm64 multiarch images locally for those brave enough to experiment with them. Refs zulip#357.
andersk
reviewed
Feb 23, 2023
alexmv
reviewed
Mar 2, 2023
There was a problem hiding this comment.
I'm not sold on introducing Makefile as a new language here -- I don't think we're gaining anything over a shell script besides arcane syntax. Specifically, none of the "use intermediate build products" feature which make Makefiles save cycles are in use here.
|
Closing to reopen with full GHA+GHCR automation (which I realize I did on a different branch...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow building amd64+arm64 multiarch images locally for those brave enough to experiment with them.
Refs #357.