dialog: Use Cupertino-flavored alert dialogs on iOS #1017

u7088495 · 2024-10-22T04:43:49Z

This pull request closes #996.

In dialog.dart:

Switched alertDialog( to alertDialog.adaptive(, as per #996.

Defined new private widget _adaptiveAction which displays a CupertinoDialogAction for IOS and a TextButton otherwise. _adaptiveAction( is used in place of TextButton( when stating dialog actions.

The new result for IOS:

dialog-checks.dart has been updated to check the text content of the respective dialog types depending on the platform

chrisbobbe

Thanks! Comments below.

Also, please tidy up the branch's commit history for clear and coherent commits. Each commit should be clean and pass all tests (you can run our tests with tools/check).

chrisbobbe · 2024-10-23T22:29:08Z

lib/widgets/dialog.dart

+/// Sets the dialog action to be platform appropriate
+/// by displaying a [CupertinoDialogAction] for IOS platforms
+/// and a regular [TextButton] otherwise.
+Widget _adaptiveAction(
+      {required BuildContext context,
+      required VoidCallback onPressed,
+      required Widget child}) {
+    final ThemeData theme = Theme.of(context);
+    switch (theme.platform) {
+      case TargetPlatform.android:
+        return TextButton(onPressed: onPressed, child: child);
+      case TargetPlatform.fuchsia:
+      return TextButton(onPressed: onPressed, child: child);
+      case TargetPlatform.linux:
+        return TextButton(onPressed: onPressed, child: child);
+      case TargetPlatform.windows:
+        return TextButton(onPressed: onPressed, child: child);
+      case TargetPlatform.iOS:
+        return CupertinoDialogAction(onPressed: onPressed, child: child);
+      case TargetPlatform.macOS:
+        return CupertinoDialogAction(onPressed: onPressed, child: child);
+    }
+  }


This can be tightened up in a few ways:

Use empty cases to fall through. From the doc on Dart switch statements:

https://dart.dev/language/branches#switch-statements

Use defaultTargetPlatform instead of passing through context. When the app is run on a device, defaultTargetPlatform will match the platform (iOS or Android). When we need to simulate a specific platform in tests, we set defaultTargetPlatform; search for debugDefaultTargetPlatformOverride for how we do this.

More concise dartdoc

Also, because the logic in _dialogActionText fits and is recommended for the Material-style dialog, let's only apply it on Android. This helper is a fine place for that conditional logic; how about changing its interface so it takes a String instead of a Widget, and applies _dialogActionText in the Android branch. In my proposal below, I've also given _dialogActionText an appropriately specific name, _materialDialogActionText. That helper could even be inlined, perhaps in a followup NFC commit.

So, putting all that together:

Suggested change

/// Sets the dialog action to be platform appropriate

/// by displaying a [CupertinoDialogAction] for IOS platforms

/// and a regular [TextButton] otherwise.

Widget _adaptiveAction(

{required BuildContext context,

required VoidCallback onPressed,

required Widget child}) {

final ThemeData theme = Theme.of(context);

switch (theme.platform) {

case TargetPlatform.android:

return TextButton(onPressed: onPressed, child: child);

case TargetPlatform.fuchsia:

return TextButton(onPressed: onPressed, child: child);

case TargetPlatform.linux:

return TextButton(onPressed: onPressed, child: child);

case TargetPlatform.windows:

return TextButton(onPressed: onPressed, child: child);

case TargetPlatform.iOS:

return CupertinoDialogAction(onPressed: onPressed, child: child);

case TargetPlatform.macOS:

return CupertinoDialogAction(onPressed: onPressed, child: child);

}

}

/// A platform-appropriate action for [AlertDialog.adaptive]'s [actions] param.

Widget _adaptiveAction({required VoidCallback onPressed, required String text}) {

switch (defaultTargetPlatform) {

case TargetPlatform.android:

case TargetPlatform.fuchsia:

case TargetPlatform.linux:

case TargetPlatform.windows:

return TextButton(onPressed: onPressed, child: _materialDialogActionText(text));

case TargetPlatform.iOS:

case TargetPlatform.macOS:

return CupertinoDialogAction(onPressed: onPressed, child: Text(text));

}

}

Is this the idea for inlining the _materialDialogActionText?

return TextButton(onPressed: onPressed, child: Text(text, textAlign: TextAlign.end));

will update the commit message of the latest commit as well as per the guidelines

chrisbobbe · 2024-10-23T22:35:19Z

test/widgets/dialog_checks.dart

@@ -6,21 +8,41 @@ import 'package:flutter_test/flutter_test.dart';
 /// Checks for an error dialog matching an expected title
 /// and, optionally, matching an expected message. Fails if none is found.
 ///
-/// On success, returns the widget's "OK" button.
+/// On success, returns the widget's "OK" button
+/// (which is a [CupertinoDialogAction] for OS platforms).


We can leave this dartdoc unchanged. It doesn't matter what specific widget the button is, as long as it responds to taps.

chrisbobbe · 2024-10-23T22:37:26Z

test/widgets/dialog_checks.dart

-  final dialog = tester.widget<AlertDialog>(find.byType(AlertDialog));
-  tester.widget(find.descendant(matchRoot: true,
-    of: find.byWidget(dialog.title!), matching: find.text(expectedTitle)));
-  if (expectedMessage != null) {
+  if (defaultTargetPlatform == TargetPlatform.iOS 
+    || defaultTargetPlatform == TargetPlatform.macOS) {
+
+    final dialog = tester.widget<CupertinoAlertDialog>(find.byType(CupertinoAlertDialog));
+
    tester.widget(find.descendant(matchRoot: true,
-      of: find.byWidget(dialog.content!), matching: find.text(expectedMessage)));
-  }
+    of: find.byWidget(dialog.title!), matching: find.text(expectedTitle)));

-  return tester.widget(
-    find.descendant(of: find.byWidget(dialog),
-      matching: find.widgetWithText(TextButton, 'OK')));
+    if (expectedMessage != null) {
+      tester.widget(find.descendant(matchRoot: true,
+        of: find.byWidget(dialog.content!), matching: find.text(expectedMessage)));
+    }
+
+    return tester.widget(
+      find.descendant(of: find.byWidget(dialog),
+        matching: find.widgetWithText(CupertinoDialogAction, 'OK')));
+
+  } 
+  else {
+    final dialog = tester.widget<Dialog>(find.byType(Dialog));
+    tester.widget(find.widgetWithText(Dialog, expectedTitle));
+    if (expectedMessage != null) {
+      tester.widget(find.widgetWithText(Dialog, expectedMessage));
+    }
+    return tester.widget(
+      find.descendant(of: find.byWidget(dialog),
+        matching: find.widgetWithText(TextButton, 'OK')));
+  }


Let's use an exhaustive switch on defaultTargetPlatform, like we do elsewhere. Also, there are several formatting nits that makes this code harder to read than it needs to be.

Proposal:

switch (defaultTargetPlatform) { case TargetPlatform.android: case TargetPlatform.fuchsia: case TargetPlatform.linux: case TargetPlatform.windows: { final dialog = tester.widget<Dialog>(find.byType(Dialog)); tester.widget(find.widgetWithText(Dialog, expectedTitle)); if (expectedMessage != null) { tester.widget(find.widgetWithText(Dialog, expectedMessage)); } return tester.widget( find.descendant(of: find.byWidget(dialog), matching: find.widgetWithText(TextButton, 'OK'))); } case TargetPlatform.iOS: case TargetPlatform.macOS: { final dialog = tester.widget<CupertinoAlertDialog>( find.byType(CupertinoAlertDialog)); tester.widget(find.descendant(matchRoot: true, of: find.byWidget(dialog.title!), matching: find.text(expectedTitle))); if (expectedMessage != null) { tester.widget(find.descendant(matchRoot: true, of: find.byWidget(dialog.content!), matching: find.text(expectedMessage))); } return tester.widget(find.descendant(of: find.byWidget(dialog), matching: find.widgetWithText(CupertinoDialogAction, 'OK'))); } }

chrisbobbe · 2024-10-23T22:38:18Z

pubspec.lock

@@ -315,10 +315,10 @@ packages:
    dependency: transitive
    description:
      name: file
-      sha256: "5fc22d7c25582e38ad9a8515372cd9a93834027aacf1801cf01164dac0ffa08c"
+      sha256: a3b4f84adafef897088c160faf7dfffb7696046cb13ae90b508c2cbc95d3b8d4


The changes to this file don't look related; please remove them.

Ok thankyou for the feedback, will be sure to onboard these points when working on issues in the future. I'll fix these things up in a new commit.

gnprice · 2024-10-24T01:40:42Z

(Misclick, sorry)

chrisbobbe

Thanks. You'll need to tidy up your branch, as I mentioned above, before we can review this again. If you need help, please ask in #git help in the development community.

lib/widgets/dialog.dart

pubspec.lock

u7088495 · 2024-10-25T01:02:38Z

Thanks. You'll need to tidy up your branch, as I mentioned above, before we can review this again. If you need help, please ask in #git help in the development community.

yep my bad, will do so. Thanks for your patients with me on this.

As was suggested in a comment of the pull request zulip#1017 (comment).

chrisbobbe

Thanks, this is much closer! Small comments below.

Also, a few commit message nits:

dialog: display adaptive dialogs and action buttons based on the target platform

AlertDialog was changed to AlertDialog.adaptive to the effect described in #996.
_adaptiveAction was implemented to display a platform appropriate action for
AlertDialog.adaptive's actions param, as was also discussed in #996.
tests in dialog_test were updated to perform platform appropriate tests.

This commit fixes an issue (🎉), so let's put a Fixes: #996 line at the end of it.
Also, I think the paragraph ("AlertDialog was changed…") doesn't add anything that's not already obvious from reading the code changes and the linked issue, so let's just delete it.

dialog [nfc]: inline _materialDialogActionTest in _adaptiveAction
    
As was suggested in a comment of the pull request https://github.com/zulip/zulip-flutter/pull/1017#discussion_r1813819656.

The URL should be on a new line; we try to wrap to 68 columns except where doing so would make things more confusing. How about:
```
As suggested at:
  https://github.com/zulip/zulip-flutter/pull/1017#discussion_r1813819656 
```

Then for both commit messages, use initial caps for the part after the prefix, so:

dialog: Display adaptive dialogs and action buttons based on the target platform
dialog [nfc]: inline _materialDialogActionTest in _adaptiveAction

For examples of commit messages in the project's style, see the project's Git history; I recommend Greg's excellent tip about how to do that.

test/widgets/dialog_checks.dart

lib/widgets/dialog.dart

As was suggested in a comment of the pull request zulip#1017 (comment).

As suggested at: zulip#1017 (comment)

chrisbobbe

Thanks!

Some new nits below, and also some more commit-message nits that I should have caught last time 🙂:

dialog: Display adaptive dialogs and action buttons based on the target platform

This summary line is too long, at 80 characters. How about:

dialog: Use Cupertino-flavored alert dialogs on iOS

This also has a bit more information: the fact that iOS was the platform getting the wrong-style dialog. (The fact that the dialog's buttons match the rest of the dialog isn't surprising enough to need a mention. 🙂)

For what the length limit actually is, see discussion, which I've just started 🙂. This was a helpful opportunity for me to spot a change in the zulip/zulip documentation that I'd missed!

dialog [nfc]: Inline _materialDialogActionTest in _adaptiveAction

The function's name is _materialDialogActionText, not _materialDialogActionTest.

lib/widgets/dialog.dart

As suggested at: zulip#1017 (comment)

u7088495 · 2024-10-30T05:01:40Z

Thanks!

Some new nits below, and also some more commit-message nits that I should have caught last time 🙂:
dialog: Display adaptive dialogs and action buttons based on the target platform
This summary line is too long, at 80 characters. How about:
dialog: Use Cupertino-flavored alert dialogs on iOS
This also has a bit more information: the fact that iOS was the platform getting the wrong-style dialog. (The fact that the dialog's buttons match the rest of the dialog isn't surprising enough to need a mention. 🙂)

For what the length limit actually is, see discussion, which I've just started 🙂. This was a helpful opportunity for me to spot a change in the zulip/zulip documentation that I'd missed!
dialog [nfc]: Inline _materialDialogActionTest in _adaptiveAction
The function's name is _materialDialogActionText, not _materialDialogActionTest.

all sorted :)

As suggested at: zulip#1017 (comment)

gnprice

Thanks for the revision! Comments below.

gnprice · 2025-02-14T04:41:25Z

test/widgets/dialog_checks.dart

+      return tester.widget(find.descendant(of: find.byWidget(dialog),
+          matching: find.widgetWithText(TextButton, 'OK')));


nit: two-space indents (like in the existing code)

Suggested change

return tester.widget(find.descendant(of: find.byWidget(dialog),

matching: find.widgetWithText(TextButton, 'OK')));

return tester.widget(find.descendant(of: find.byWidget(dialog),

matching: find.widgetWithText(TextButton, 'OK')));

gnprice · 2025-02-14T04:44:49Z

test/widgets/dialog_checks.dart

+      }
+
+      return tester.widget(find.descendant(of: find.byWidget(dialog),


nit: avoid trailing whitespace

Suggested change

}

return tester.widget(find.descendant(of: find.byWidget(dialog),

}

return tester.widget(find.descendant(of: find.byWidget(dialog),

If you use git log -p to read through your changes for self-review, Git should highlight this sort of whitespace error for you. Here's how it looks in my terminal:

gnprice · 2025-02-14T04:45:55Z

lib/widgets/dialog.dart

 import 'package:flutter/material.dart';
+import 'package:flutter/cupertino.dart';
+import 'package:flutter/foundation.dart';


nit: keep imports sorted

gnprice · 2025-02-14T04:50:19Z

lib/widgets/dialog.dart

-          onPressed: () {
-            onActionButtonPress();
-            Navigator.pop(context);


Why does the Navigator.pop get removed here? That seems like a substantive change unrelated to switching to Cupertino style.

It looks like this was probably an error in resolving rebase conflicts. Mistakes there happen, but that's one of the reasons it's important to reread your changes when sending them for review:
https://zulip.readthedocs.io/en/latest/contributing/code-reviewing.html#reviewing-your-own-code

There are also some important tips that can make it a lot easier to resolve rebase/merge conflicts correctly, including a Git config setting (merge.conflictstyle diff3) that is tragically not the default but you should definitely set. Details here:
https://chat.zulip.org/#narrow/channel/243-mobile-team/topic/rebase.20conflicts/near/1136429
https://chat.zulip.org/#narrow/stream/2-general/topic/navigating.20code.20review.3A.20Rebasing.20work/near/1737371

Also in the latter thread are tips about self-review specifically for the result of rebasing, starting at this message:
https://chat.zulip.org/#narrow/channel/2-general/topic/navigating.20code.20review.3A.20Rebasing.20work/near/1737381

Yep that's my mistake, thanks for the materials - I'll make an effort to be more thorough about it

gnprice · 2025-02-14T04:54:27Z

test/widgets/dialog_checks.dart

+    case TargetPlatform.fuchsia:
+    case TargetPlatform.linux:
+    case TargetPlatform.windows:
+      check(find.byType(Dialog)).findsNothing();


Does this work correctly?

It looks like it would just always pass. Remember what we saw about find.byType here: #1017 (comment)

I'm fairly sure this works correctly - a Dialog widget is generated in the widget tree by AlertDialog.adaptive, and the check failed when I moved it to checkErrorDialog.

Would it still be better to use find.byType?

Hmm, right, AlertDialog builds a Dialog child rather than subclassing it. And there are no subclasses of Dialog.

find.byType is fine, then.

Still, we can make this check stronger:

No need for the switch — just unconditionally check there's no Dialog, and also no CupertinoAlertDialog. After all, if we did somehow end up with a Dialog on iOS or a CupertinoAlertDialog on Android, that would probably be a bug; and it definitely wouldn't be a case of there being "no dialog", so this checkNoDialog function should fail.

Reading this code and comparing to checkErrorDialog and checkSuggestedActionDialog still makes me nervous that they don't seem to line up — it sure looks as if there might be cases where one of those passes and yet this also passes. (The only reason that's impossible is a fact about the details of how AlertDialog works, which is that it uses Dialog as a child.)

To fix that, this should use have a find.bySubtype<AlertDialog> check too. The find.byType(Dialog) is a good additional check to make sure there isn't some unexpected other type of dialog, but it doesn't substitute for directly checking that the scenario in the other checks can't be happening.

sure thing that all makes sense.
Should I also add in a find.byType(AlertDialog) check for the sake of thoroughness as well? To ensure that no dialog has been created using the AlertDialog constructor directly.

The find.bySubtype<AlertDialog> check should cover that, right?

gnprice · 2025-02-14T05:00:00Z

test/widgets/dialog_checks.dart

+      final actionButton = tester.widget(find.descendant(of: find.byWidget(dialog),
+          matching: find.widgetWithText(CupertinoDialogAction, expectedActionButtonText ?? 'Continue')));
+
+      final cancelButton = tester.widget(find.descendant(of: find.byWidget(dialog),
+          matching: find.widgetWithText(CupertinoDialogAction, 'Cancel')));
+
+      return (actionButton, cancelButton);


nit: group these as one stanza:

Suggested change

final actionButton = tester.widget(find.descendant(of: find.byWidget(dialog),

matching: find.widgetWithText(CupertinoDialogAction, expectedActionButtonText ?? 'Continue')));

final cancelButton = tester.widget(find.descendant(of: find.byWidget(dialog),

matching: find.widgetWithText(CupertinoDialogAction, 'Cancel')));

return (actionButton, cancelButton);

final actionButton = tester.widget(find.descendant(of: find.byWidget(dialog),

matching: find.widgetWithText(CupertinoDialogAction, expectedActionButtonText ?? 'Continue')));

final cancelButton = tester.widget(find.descendant(of: find.byWidget(dialog),

matching: find.widgetWithText(CupertinoDialogAction, 'Cancel')));

return (actionButton, cancelButton);

That helps in seeing the overall organization, since there's now this extra layer of structure around these that is the switch statement.

gnprice · 2025-02-14T05:05:04Z

test/widgets/dialog_test.dart

+      String title = "Dialog Title";
+      String message = "Dialog message.";


nit: where possible, declare final (or in fact const)

gnprice · 2025-02-14T05:05:49Z

test/widgets/dialog_test.dart

+  group('showErrorDialog', () {
+    testWidgets('show error dialog', (tester) async {


nit: the test name says the same thing as the group name — no need for the group

gnprice · 2025-02-14T05:08:10Z

test/widgets/dialog_test.dart

+import 'dialog_checks.dart';
+import 'test_app.dart';
+
+void main() {


Cool, these tests look broadly right.

Let's have them check one other important aspect: each of the buttons in the dialog does the intended thing if you tap it.

As suggested at: zulip#1017 (comment)

Fixes: zulip#996

As suggested at: zulip#1017 (comment)

u7088495 marked this pull request as ready for review October 22, 2024 13:59

chrisbobbe reviewed Oct 23, 2024

View reviewed changes

gnprice added the maintainer review PR ready for review by Zulip maintainers label Oct 23, 2024

gnprice closed this Oct 24, 2024

gnprice reopened this Oct 24, 2024

u7088495 force-pushed the cupertino-dialog-for-ios branch 4 times, most recently from a255919 to db740f9 Compare October 24, 2024 04:34

chrisbobbe reviewed Oct 25, 2024

View reviewed changes

lib/widgets/dialog.dart Show resolved Hide resolved

pubspec.lock Outdated Show resolved Hide resolved

u7088495 force-pushed the cupertino-dialog-for-ios branch 2 times, most recently from ed8abb7 to 9d2c4df Compare October 25, 2024 01:30

u7088495 added a commit to u7088495/zulip-flutter that referenced this pull request Oct 25, 2024

dialog [nfc]: inline _materialDialogActionTest in _adaptiveAction

373cd75

As was suggested in a comment of the pull request zulip#1017 (comment).

u7088495 force-pushed the cupertino-dialog-for-ios branch from 9e6fc98 to 373cd75 Compare October 25, 2024 02:17

chrisbobbe requested changes Oct 25, 2024

View reviewed changes

test/widgets/dialog_checks.dart Outdated Show resolved Hide resolved

test/widgets/dialog_checks.dart Outdated Show resolved Hide resolved

lib/widgets/dialog.dart Outdated Show resolved Hide resolved

u7088495 added a commit to u7088495/zulip-flutter that referenced this pull request Oct 26, 2024

dialog [nfc]: inline _materialDialogActionTest in _adaptiveAction

52d762d

As was suggested in a comment of the pull request zulip#1017 (comment).

u7088495 force-pushed the cupertino-dialog-for-ios branch from 373cd75 to 52d762d Compare October 26, 2024 23:26

u7088495 added a commit to u7088495/zulip-flutter that referenced this pull request Oct 26, 2024

dialog [nfc]: Inline _materialDialogActionTest in _adaptiveAction

6166a0a

As suggested at: zulip#1017 (comment)

u7088495 force-pushed the cupertino-dialog-for-ios branch from 52d762d to 6166a0a Compare October 26, 2024 23:55

u7088495 added a commit to u7088495/zulip-flutter that referenced this pull request Oct 27, 2024

dialog [nfc]: Inline _materialDialogActionTest in _adaptiveAction

f91a8c5

As suggested at: zulip#1017 (comment)

u7088495 force-pushed the cupertino-dialog-for-ios branch from 6166a0a to f91a8c5 Compare October 27, 2024 00:03

u7088495 requested a review from chrisbobbe October 27, 2024 00:09

u7332137 approved these changes Oct 27, 2024

View reviewed changes

chrisbobbe self-assigned this Oct 28, 2024

chrisbobbe reviewed Oct 29, 2024

View reviewed changes

lib/widgets/dialog.dart Outdated Show resolved Hide resolved

lib/widgets/dialog.dart Outdated Show resolved Hide resolved

u7088495 added a commit to u7088495/zulip-flutter that referenced this pull request Oct 30, 2024

dialog [nfc]: Inline _materialDialogActionText in _adaptiveAction

0a44828

As suggested at: zulip#1017 (comment)

u7088495 force-pushed the cupertino-dialog-for-ios branch from f91a8c5 to 0a44828 Compare October 30, 2024 04:56

u7088495 force-pushed the cupertino-dialog-for-ios branch from 2f8cd8b to 8f95cff Compare February 10, 2025 22:16

u7088495 added a commit to u7088495/zulip-flutter that referenced this pull request Feb 11, 2025

dialog [nfc]: Inline _materialDialogActionText in _adaptiveAction

b57c97e

As suggested at: zulip#1017 (comment)

u7088495 force-pushed the cupertino-dialog-for-ios branch from 8f95cff to b57c97e Compare February 11, 2025 00:20

u7088495 added a commit to u7088495/zulip-flutter that referenced this pull request Feb 11, 2025

dialog [nfc]: Inline _materialDialogActionText in _adaptiveAction

2341baf

As suggested at: zulip#1017 (comment)

u7088495 force-pushed the cupertino-dialog-for-ios branch from b57c97e to 2341baf Compare February 11, 2025 00:31

u7088495 added a commit to u7088495/zulip-flutter that referenced this pull request Feb 11, 2025

dialog [nfc]: Inline _materialDialogActionText in _adaptiveAction

a9c1daf

As suggested at: zulip#1017 (comment)

u7088495 force-pushed the cupertino-dialog-for-ios branch from 2341baf to a9c1daf Compare February 11, 2025 00:34

u7088495 added a commit to u7088495/zulip-flutter that referenced this pull request Feb 11, 2025

dialog [nfc]: Inline _materialDialogActionText in _adaptiveAction

45ed11e

As suggested at: zulip#1017 (comment)

u7088495 force-pushed the cupertino-dialog-for-ios branch from a9c1daf to 45ed11e Compare February 11, 2025 00:35

u7088495 added a commit to u7088495/zulip-flutter that referenced this pull request Feb 11, 2025

dialog [nfc]: Inline _materialDialogActionText in _adaptiveAction

ad45ea5

As suggested at: zulip#1017 (comment)

u7088495 force-pushed the cupertino-dialog-for-ios branch from 45ed11e to ad45ea5 Compare February 11, 2025 00:58

u7088495 added a commit to u7088495/zulip-flutter that referenced this pull request Feb 11, 2025

dialog [nfc]: Inline _materialDialogActionText in _adaptiveAction

b2ce0c0

As suggested at: zulip#1017 (comment)

u7088495 force-pushed the cupertino-dialog-for-ios branch 3 times, most recently from 40f7646 to b361f70 Compare February 11, 2025 05:13

u7088495 added a commit to u7088495/zulip-flutter that referenced this pull request Feb 11, 2025

dialog [nfc]: Inline _materialDialogActionText in _adaptiveAction

7e9b5d6

As suggested at: zulip#1017 (comment)

u7088495 force-pushed the cupertino-dialog-for-ios branch from b361f70 to c253497 Compare February 11, 2025 05:17

u7088495 added a commit to u7088495/zulip-flutter that referenced this pull request Feb 11, 2025

dialog [nfc]: Inline _materialDialogActionText in _adaptiveAction

346919b

As suggested at: zulip#1017 (comment)

u7088495 force-pushed the cupertino-dialog-for-ios branch from c253497 to 343870b Compare February 11, 2025 05:21

u7088495 added a commit to u7088495/zulip-flutter that referenced this pull request Feb 14, 2025

dialog [nfc]: Inline _materialDialogActionText in _adaptiveAction

12007bb

As suggested at: zulip#1017 (comment)

u7088495 force-pushed the cupertino-dialog-for-ios branch from 343870b to 2ef257b Compare February 14, 2025 00:56

u7088495 requested a review from gnprice February 14, 2025 00:57

gnprice reviewed Feb 14, 2025

View reviewed changes

chrisbobbe mentioned this pull request Feb 14, 2025

Message List from Same User is now Distinguishable via Surface Tint on Long Press #1152

Open

u7088495 added a commit to u7088495/zulip-flutter that referenced this pull request Feb 28, 2025

dialog [nfc]: Inline _materialDialogActionText in _adaptiveAction

f510e7b

As suggested at: zulip#1017 (comment)

u7088495 force-pushed the cupertino-dialog-for-ios branch from 2ef257b to 5761c46 Compare February 28, 2025 05:08

u7088495 added 3 commits February 28, 2025 16:19

dialog: Use Cupertino-flavored alert dialogs on iOS

8e0d480

Fixes: zulip#996

dialog [nfc]: Inline _materialDialogActionText in _adaptiveAction

6c010b1

As suggested at: zulip#1017 (comment)

dialog [nfc]: Rename checkNoErrorDialog to checkNoDialog

f2739dd

u7088495 force-pushed the cupertino-dialog-for-ios branch from 5761c46 to f2739dd Compare February 28, 2025 05:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dialog: Use Cupertino-flavored alert dialogs on iOS #1017

dialog: Use Cupertino-flavored alert dialogs on iOS #1017

u7088495 commented Oct 22, 2024 •

edited

Loading

chrisbobbe left a comment

chrisbobbe Oct 23, 2024

u7088495 Oct 24, 2024

chrisbobbe Oct 23, 2024

chrisbobbe Oct 23, 2024

chrisbobbe Oct 23, 2024

u7088495 Oct 24, 2024

gnprice commented Oct 24, 2024

chrisbobbe left a comment

u7088495 commented Oct 25, 2024

chrisbobbe left a comment •

edited

Loading

chrisbobbe left a comment

u7088495 commented Oct 30, 2024

gnprice left a comment

gnprice Feb 14, 2025

gnprice Feb 14, 2025

gnprice Feb 14, 2025

gnprice Feb 14, 2025

gnprice Feb 14, 2025

gnprice Feb 14, 2025

u7088495 Feb 16, 2025

gnprice Feb 14, 2025

u7088495 Feb 16, 2025

gnprice Feb 18, 2025

u7088495 Feb 20, 2025 •

edited

Loading

gnprice Feb 20, 2025

gnprice Feb 14, 2025

gnprice Feb 14, 2025

gnprice Feb 14, 2025

gnprice Feb 14, 2025

		return tester.widget(find.descendant(of: find.byWidget(dialog),
		matching: find.widgetWithText(TextButton, 'OK')));

		String title = "Dialog Title";
		String message = "Dialog message.";

		group('showErrorDialog', () {
		testWidgets('show error dialog', (tester) async {

dialog: Use Cupertino-flavored alert dialogs on iOS #1017

Are you sure you want to change the base?

dialog: Use Cupertino-flavored alert dialogs on iOS #1017

Conversation

u7088495 commented Oct 22, 2024 • edited Loading

chrisbobbe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gnprice commented Oct 24, 2024

chrisbobbe left a comment

Choose a reason for hiding this comment

u7088495 commented Oct 25, 2024

chrisbobbe left a comment • edited Loading

Choose a reason for hiding this comment

chrisbobbe left a comment

Choose a reason for hiding this comment

u7088495 commented Oct 30, 2024

gnprice left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

u7088495 Feb 20, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

u7088495 commented Oct 22, 2024 •

edited

Loading

chrisbobbe left a comment •

edited

Loading

u7088495 Feb 20, 2025 •

edited

Loading