Cleaned up stuff, and a new simplify_string transform #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 96.46% 94.98% -1.49%
==========================================
Files 29 30 +1
Lines 1075 1136 +61
Branches 160 168 +8
==========================================
+ Hits 1037 1079 +42
- Misses 16 34 +18
- Partials 22 23 +1
Continue to review full report at Codecov.
|
ErikBjare
changed the title
aw_analysis/query2_functions.py
Outdated
|
|
||
|
|
||
| @q2_function | ||
| def q2_query_bucket(datastore: Datastore, namespace: dict, bucketname: str) -> List[Event]: |
aw_analysis/query2_functions.py
Outdated
| def q2_query_bucket_eventcount(datastore: Datastore, namespace: dict, bucketname: str): | ||
|
|
||
| @q2_function | ||
| def q2_query_bucket_eventcount(datastore: Datastore, namespace: dict, bucketname: str) -> int: |
aw_analysis/query2_functions.py
Outdated
|
|
||
|
|
||
| @q2_function | ||
| def q2_filter_keyvals(datastore: Datastore, namespace: dict, events: list, key: str, *vals) -> List[Event]: |
aw_analysis/query2_functions.py
Outdated
| def q2_exclude_keyvals(datastore: Datastore, namespace: dict, events: list, key: str, *vals): | ||
|
|
||
| @q2_function | ||
| def q2_exclude_keyvals(datastore: Datastore, namespace: dict, events: list, key: str, *vals) -> List[Event]: |
aw_analysis/query2_functions.py
Outdated
| def q2_filter_period_intersect(datastore: Datastore, namespace: dict, events: list, filterevents: list): | ||
|
|
||
| @q2_function | ||
| def q2_filter_period_intersect(datastore: Datastore, namespace: dict, events: list, filterevents: list) -> List[Event]: |
aw_analysis/query2_functions.py
Outdated
|
|
||
|
|
||
| @q2_function | ||
| def q2_merge_events_by_keys(datastore: Datastore, namespace: dict, events: list, *keys) -> List[Event]: |
aw_analysis/query2_functions.py
Outdated
|
|
||
|
|
||
| @q2_function | ||
| def q2_sort_by_timestamp(datastore: Datastore, namespace: dict, events: list) -> List[Event]: |
aw_analysis/query2_functions.py
Outdated
| def q2_sort_by_duration(datastore: Datastore, namespace: dict, events: list): | ||
|
|
||
| @q2_function | ||
| def q2_sort_by_duration(datastore: Datastore, namespace: dict, events: list) -> List[Event]: |
aw_analysis/query2_functions.py
Outdated
| def q2_split_url_events(datastore: Datastore, namespace: dict, events: list): | ||
|
|
||
| @q2_function | ||
| def q2_split_url_events(datastore: Datastore, namespace: dict, events: list) -> List[Event]: |
aw_analysis/query2_functions.py
Outdated
| _verify_variable_is_type(events, list) | ||
| return split_url_events(events) | ||
|
|
||
|
|
||
| @q2_function | ||
| def q2_simplify_window_titles(datastore: Datastore, namespace: dict, events: list, key: str) -> List[Event]: |
|
Made the final fixes and I'm just going to go ahead and merge this. Some pretty good stuff imho! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplify_stringtransform + testq2_functiondecorator for registering query functionspytest.raiseswhere appropriate in testsq2_find_bucketto avoid hardcoding bucket IDs in queriesq2_filter_keyvals_regexTODO