Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove netstat debugging #126

Merged
merged 2 commits into from
Apr 19, 2024
Merged

chore: remove netstat debugging #126

merged 2 commits into from
Apr 19, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Mar 8, 2024

refs: #93

We haven't seen that flake since the hypothesized fix #93 (comment)

The debugging output of netstat causes the logs to grow too large for Github's UI to search them. So let's not wait any longer to remove the output.

I don't think this will really solve #93 so this doesn't close it

@turadg turadg requested a review from 0xpatrickdev March 8, 2024 20:45
@turadg
Copy link
Member Author

turadg commented Mar 8, 2024

Curiously, removing the debugging output re-triggered the error I thought was fixed:

#0 1.611 Error: failed to listen on 0.0.0.0:26657: listen tcp 0.0.0.0:26657: bind: address already in use
#0 1.611 8:45PM ERR pprof server error err="listen tcp 127.0.0.1:6060: bind: address already in use"

@turadg turadg marked this pull request as draft March 8, 2024 21:22
@turadg turadg force-pushed the 93-port-debugging branch 4 times, most recently from a9f68bc to f6b824c Compare March 13, 2024 19:00
# XXX debugging https://github.com/Agoric/agoric-3-proposals/issues/93
apt install net-tools
netstat
# precondition check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#127 (comment)

Suggested change
# precondition check
# XXX debugging https://github.com/Agoric/agoric-3-proposals/issues/93
apt install net-tools
netstat -plnA inet
# precondition check

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is to remove the netstat debugging. The underlying cause is that agd is already bound to the ports. I don't know the cause of that but this hacks around it by waiting for it to die.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I'm trying to get to the bottom of that with a more useful invocation of netstat.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I thought you were suggesting a change in this PR. If you want to figure out the cause of failures in #127 I thought you'd push to that branch whatever logging you need.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm putting this up for review again because I think we should keep those netstat logs out of main. They make the logs unwieldy to scroll in the Github UI

@turadg turadg marked this pull request as ready for review April 19, 2024 00:23
@turadg turadg requested a review from gibson042 April 19, 2024 00:23
@turadg
Copy link
Member Author

turadg commented Apr 19, 2024

merging without review to help debug trunk.

@turadg turadg merged commit cf9e09c into main Apr 19, 2024
4 checks passed
@turadg turadg deleted the 93-port-debugging branch April 19, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake: binding port already in use
2 participants