Added a verb to enable the browser devtools on 516 #20427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FluffyGhoster
requested review from
Arrow768 and
NonQueueingMatt
as code owners
|
!review |
Arrow768
requested changes
Feb 3, 2025
| /** | ||
| * Enable Edge Dev Tools | ||
| */ | ||
| /client/proc/allow_browser_inspect() |
There was a problem hiding this comment.
The proc itself should also contain a permissions check
There was a problem hiding this comment.
Scrolling up from the proc, there's various other procs (some I wrote, some I didn't) like this, that's because the only way to access the proc is by it being assigned to you, which seems sufficient (?)
There was a problem hiding this comment.
It should be sufficient but from a security perspective it is better to also check for proper permissions on the actual proc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a verb to enable the browser devtools on 516