Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a verb to enable the browser devtools on 516 #20427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions code/modules/admin/admin_verbs.dm
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ var/list/admin_verbs_debug = list(
/client/proc/cmd_display_harddel_log,
/client/proc/cmd_display_init_log,
/client/proc/cmd_generate_lag,
/client/proc/allow_browser_inspect,
/client/proc/cmd_ss_panic,
/client/proc/reset_openturf,
/datum/admins/proc/capture_map,
Expand Down Expand Up @@ -397,6 +398,7 @@ var/list/admin_verbs_hideable = list(
/datum/admins/proc/set_odyssey,
/client/proc/cmd_display_init_log,
/client/proc/cmd_generate_lag,
/client/proc/allow_browser_inspect,
/client/proc/getruntimelog,
/client/proc/toggledebuglogs,
/client/proc/getserverlog,
Expand Down Expand Up @@ -484,6 +486,7 @@ var/list/admin_verbs_dev = list( //will need to be altered - Ryan784
/client/proc/cmd_display_harddel_log,
/client/proc/cmd_display_init_log,
/client/proc/cmd_generate_lag,
/client/proc/allow_browser_inspect,
/client/proc/create_poll, //Allows to create polls
/client/proc/profiler_start,
)
Expand Down
19 changes: 19 additions & 0 deletions code/modules/admin/verbs/debug.dm
Original file line number Diff line number Diff line change
Expand Up @@ -499,3 +499,22 @@
for(var/atom/an_atom in world)
if(world.tick_usage > (100+(tick_offenses+jitter_this_run)))
stoplag()

/**
* Enable Edge Dev Tools
*/
/client/proc/allow_browser_inspect()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proc itself should also contain a permissions check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scrolling up from the proc, there's various other procs (some I wrote, some I didn't) like this, that's because the only way to access the proc is by it being assigned to you, which seems sufficient (?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be sufficient but from a security perspective it is better to also check for proper permissions on the actual proc.

set name = "Allow Browser Inspect"
set category = "Debug"
set desc = "Allow browser debugging via inspect"

var/client/client_caller = get_client(usr)
if(!istype(client_caller))
return

if(client_caller.byond_version < 516)
to_chat(client_caller, SPAN_WARNING("You can only use this on 516!"))
return

to_chat(client_caller, SPAN_NOTICE("You can now right click to use inspect on browsers."))
winset(client_caller, null, list("browser-options" = "+devtools"))
58 changes: 58 additions & 0 deletions html/changelogs/fluffyghost-516devtoolinspect.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
################################
# Example Changelog File
#
# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb.
#
# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.)
# When it is, any changes listed below will disappear.
#
# Valid Prefixes:
# bugfix
# - (fixes bugs)
# wip
# - (work in progress)
# qol
# - (quality of life)
# soundadd
# - (adds a sound)
# sounddel
# - (removes a sound)
# rscadd
# - (adds a feature)
# rscdel
# - (removes a feature)
# imageadd
# - (adds an image or sprite)
# imagedel
# - (removes an image or sprite)
# spellcheck
# - (fixes spelling or grammar)
# experiment
# - (experimental change)
# balance
# - (balance changes)
# code_imp
# - (misc internal code change)
# refactor
# - (refactors code)
# config
# - (makes a change to the config files)
# admin
# - (makes changes to administrator tools)
# server
# - (miscellaneous changes to server)
#################################

# Your name.
author: FluffyGhost

# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again.
delete-after: True

# Any changes you've made. See valid prefix list above.
# INDENT WITH TWO SPACES. NOT TABS. SPACES.
# SCREW THIS UP AND IT WON'T WORK.
# Also, this gets changed to [] after reading. Just remove the brackets when you add new shit.
# Please surround your changes in double quotes ("). It works without them, but if you use certain characters it screws up compiling. The quotes will not show up in the changelog.
changes:
- admin: "Added a verb to enable the browser devtools on 516."
Loading