Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Shopper BNPL Checkout spec #10177

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ismaeldcom
Copy link
Contributor

Fixes #10060

Changes proposed in this Pull Request

  • Modify shopper utils to implement expectFraudPreventionToken and selectPaymentMethod and update setupProductCheckout.
  • Refactor affected tests by setupProductCheckout update.
  • Implement Playwright shopper-bnpls-checkout spec
  • Remove Puppeteer shopper-bnpls-checkout spec

Testing instructions

  • Checkout dev/10060-convert-shopper-bnpls-checkout-spec
  • Run npm run test:e2e-pw bnpls
  • Test should pass locally.
  • Test should pass in GH actions.

  • Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Post merge

@ismaeldcom ismaeldcom self-assigned this Jan 17, 2025
@botwoo

This comment was marked as off-topic.

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E Playwright Migration: convert shopper-bnpls-checkout spec
2 participants