Dev - Fix E2E tests in Node v20 #9132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Size Change: 0 B
Total Size: 1.29 MB
ℹ️ View Unchanged
| Filename | Size |
|---|---|
release/woocommerce-payments/assets/css/admin.css |
1.08 kB |
release/woocommerce-payments/assets/css/admin.rtl.css |
1.08 kB |
release/woocommerce-payments/assets/css/success.css |
173 B |
release/woocommerce-payments/assets/css/success.rtl.css |
173 B |
release/woocommerce-payments/dist/blocks-checkout-rtl.css |
2.08 kB |
release/woocommerce-payments/dist/blocks-checkout.css |
2.08 kB |
release/woocommerce-payments/dist/blocks-checkout.js |
61.3 kB |
release/woocommerce-payments/dist/bnpl-announcement-rtl.css |
528 B |
release/woocommerce-payments/dist/bnpl-announcement.css |
529 B |
release/woocommerce-payments/dist/bnpl-announcement.js |
20.8 kB |
release/woocommerce-payments/dist/cart-block.js |
16 kB |
release/woocommerce-payments/dist/cart.js |
5.63 kB |
release/woocommerce-payments/dist/checkout-rtl.css |
600 B |
release/woocommerce-payments/dist/checkout.css |
600 B |
release/woocommerce-payments/dist/checkout.js |
31.6 kB |
release/woocommerce-payments/dist/express-checkout-rtl.css |
219 B |
release/woocommerce-payments/dist/express-checkout.css |
219 B |
release/woocommerce-payments/dist/express-checkout.js |
6.27 kB |
release/woocommerce-payments/dist/index-rtl.css |
39 kB |
release/woocommerce-payments/dist/index.css |
39 kB |
release/woocommerce-payments/dist/index.js |
295 kB |
release/woocommerce-payments/dist/multi-currency-analytics.js |
1.08 kB |
release/woocommerce-payments/dist/multi-currency-rtl.css |
3.41 kB |
release/woocommerce-payments/dist/multi-currency-switcher-block.js |
60.5 kB |
release/woocommerce-payments/dist/multi-currency.css |
3.41 kB |
release/woocommerce-payments/dist/multi-currency.js |
55.5 kB |
release/woocommerce-payments/dist/order-rtl.css |
730 B |
release/woocommerce-payments/dist/order.css |
730 B |
release/woocommerce-payments/dist/order.js |
42.7 kB |
release/woocommerce-payments/dist/payment-gateways-rtl.css |
1.35 kB |
release/woocommerce-payments/dist/payment-gateways.css |
1.35 kB |
release/woocommerce-payments/dist/payment-gateways.js |
39.2 kB |
release/woocommerce-payments/dist/payment-request-rtl.css |
219 B |
release/woocommerce-payments/dist/payment-request.css |
219 B |
release/woocommerce-payments/dist/payment-request.js |
5.89 kB |
release/woocommerce-payments/dist/plugins-page-rtl.css |
386 B |
release/woocommerce-payments/dist/plugins-page.css |
386 B |
release/woocommerce-payments/dist/plugins-page.js |
20.1 kB |
release/woocommerce-payments/dist/product-details-rtl.css |
397 B |
release/woocommerce-payments/dist/product-details.css |
398 B |
release/woocommerce-payments/dist/product-details.js |
11.2 kB |
release/woocommerce-payments/dist/settings-rtl.css |
11.2 kB |
release/woocommerce-payments/dist/settings.css |
11.1 kB |
release/woocommerce-payments/dist/settings.js |
216 kB |
release/woocommerce-payments/dist/subscription-edit-page.js |
703 B |
release/woocommerce-payments/dist/subscription-product-onboarding-modal-rtl.css |
524 B |
release/woocommerce-payments/dist/subscription-product-onboarding-modal.css |
524 B |
release/woocommerce-payments/dist/subscription-product-onboarding-modal.js |
20.2 kB |
release/woocommerce-payments/dist/subscription-product-onboarding-toast.js |
730 B |
release/woocommerce-payments/dist/subscriptions-empty-state-rtl.css |
120 B |
release/woocommerce-payments/dist/subscriptions-empty-state.css |
120 B |
release/woocommerce-payments/dist/subscriptions-empty-state.js |
19.3 kB |
release/woocommerce-payments/dist/tokenized-payment-request-rtl.css |
219 B |
release/woocommerce-payments/dist/tokenized-payment-request.css |
219 B |
release/woocommerce-payments/dist/tokenized-payment-request.js |
6.61 kB |
release/woocommerce-payments/dist/tos-rtl.css |
235 B |
release/woocommerce-payments/dist/tos.css |
235 B |
release/woocommerce-payments/dist/tos.js |
21.8 kB |
release/woocommerce-payments/dist/woopay-direct-checkout.js |
6.01 kB |
release/woocommerce-payments/dist/woopay-express-button-rtl.css |
219 B |
release/woocommerce-payments/dist/woopay-express-button.css |
219 B |
release/woocommerce-payments/dist/woopay-express-button.js |
16.2 kB |
release/woocommerce-payments/dist/woopay-rtl.css |
4.26 kB |
release/woocommerce-payments/dist/woopay.css |
4.23 kB |
release/woocommerce-payments/dist/woopay.js |
70.3 kB |
release/woocommerce-payments/includes/subscriptions/assets/css/plugin-page.css |
625 B |
release/woocommerce-payments/includes/subscriptions/assets/js/plugin-page.js |
814 B |
release/woocommerce-payments/vendor/automattic/jetpack-assets/build/i18n-loader.js |
2.46 kB |
release/woocommerce-payments/vendor/automattic/jetpack-assets/src/js/i18n-loader.js |
1.02 kB |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-admin-create-user.css |
198 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-admin-create-user.js |
20 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-admin-create-user.rtl.css |
198 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-login.css |
625 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-login.js |
20 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-login.rtl.css |
626 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-users.js |
392 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-ajax.js |
521 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-callables.js |
584 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-admin-create-user.css |
215 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-admin-create-user.js |
521 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-login.css |
721 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-login.js |
412 B |
release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-users.js |
520 B |
release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/babel.config.js |
159 B |
release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.css |
2.36 kB |
release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.js |
13.6 kB |
release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.rtl.css |
2.36 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/about.css |
1.04 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-empty-state.css |
294 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-order-statuses.css |
408 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin.css |
3.59 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/checkout.css |
301 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/modal.css |
746 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/view-subscription.css |
574 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/wcs-upgrade.css |
414 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin-pointers.js |
543 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin.js |
9.4 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.js |
6.78 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.min.js |
3.84 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-coupon.js |
545 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-subscription.js |
2.52 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.js |
22.2 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.min.js |
11.7 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/payment-method-restrictions.js |
1.29 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/wcs-meta-boxes-order.js |
507 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/payment-methods.js |
358 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/single-product.js |
428 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/view-subscription.js |
1.38 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/wcs-cart.js |
782 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/modal.js |
1.09 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/wcs-upgrade.js |
1.26 kB |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.css |
391 B |
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.js |
3.04 kB |
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
6 tasks
danielmx-dev
force-pushed
the
dev/upgrade-support-to-node-20-fix-e2e-tests
branch
from
e3afb77 to
1deac8a
Compare
|
Here's the last two manuals E2E tests runs using this branch so it can be verified that it works as expected: https://github.com/Automattic/woocommerce-payments/actions/runs/10045053899 You can see all previous runs using this branch by following here: https://github.com/Automattic/woocommerce-payments/actions/workflows/e2e-test.yml?query=branch%3Adev%2Fupgrade-support-to-node-20-fix-e2e-tests |
danielmx-dev
changed the title
frosso
approved these changes
Jul 23, 2024
Comment on lines
7
to
9
| // Wait a few seconds before tearing down the page so we | ||
| // have time to take screenshots and handle other events | ||
| await this.global.page.waitForTimeout( 1000 ); |
There was a problem hiding this comment.
Did you have a chance to investigate some alternatives than using a timeout of 1s?
Just curious, not a blocker - it'll do for now :) albeit it looks like it's a pretty common practice :) https://github.com/search?q=%22Wait+a+few+seconds+before+tearing+down+the+page+so+we%22&type=code
There was a problem hiding this comment.
I grabbed the solution from this discussion since it didn't seem to be built in any of the packages we are using.
However, it looks like the timeout shouldn't be necessary anymore since now jest and jest-circus provide full support for async event handlers since version 25.3.0.
I'll remove it!
danielmx-dev
merged commit 035d462
into
dev/upgrade-support-to-node-20
21 checks passed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9116
Changes proposed in this Pull Request
puppeteerwere not updated to their latest versions since some functions (like.$xandwaitForTimeout) were deprecated from the library. We will be able to update once@woocommerce/e2e-utilsremoved all deprecated references as well. That should be done as a separate task.puppeteerfunctionsTesting instructions
tests/e2e/README.mdto run the tests locally.Run workflowand choosing this branch.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge