{Compute} az ppg: Migrate to Code Gen V2
#30802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanzhudd
requested review from
zhoxing-ms,
jsntcy and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
Compute
|
|
zhoxing-ms
reviewed
Feb 11, 2025
Comment on lines
91
to
+92
| def error_format(self): | ||
| return "ODataV4Format" | ||
| return "MgmtErrorFormat" |
There was a problem hiding this comment.
May I ask why the error_format will change? What impact will this change have on customers?
There was a problem hiding this comment.
It should be 2020-06-01 for the command in this profile, but it was mistakely set to 2022-11-01 in an old PR. Now this PR will correct the API version. I think the change of error_format is due to the downgrade of API version.
There was a problem hiding this comment.
MgmtErrorFormat is a more detailed error format than ODataV4Format. There's no breaking change.
zhoxing-ms
previously approved these changes
Feb 13, 2025
zhoxing-ms
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az ppg create/update/listDescription
Migrate
ppgcommand group to Code Gen V2AAZ PR: Azure/aaz#689
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.