Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Compute} az ppg: Migrate to Code Gen V2 #30802

Merged
merged 3 commits into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions src/azure-cli/azure/cli/command_modules/vm/_help.py
Original file line number Diff line number Diff line change
Expand Up @@ -670,48 +670,6 @@
az image builder show -n mytemplate -g my-group
"""

helps['ppg create'] = """
type: command
short-summary: Create a proximity placement group
examples:
- name: Create a proximity placement group (autogenerated)
text: |
az ppg create --name MyProximityPlacementGroup --resource-group MyResourceGroup
crafted: true
- name: Create a proximity placement group with specifying VM sizes that can be created.
text: |
az ppg create --name MyProximityPlacementGroup --resource-group MyResourceGroup \\
--intent-vm-sizes Standard_E64s_v4 Standard_M416ms_v2
- name: Create a proximity placement group with specifying VM sizes that can be created and availability zone.
text: |
az ppg create --name MyProximityPlacementGroup --resource-group MyResourceGroup \\
--intent-vm-sizes Standard_E64s_v4 Standard_M416ms_v2 --zone 1
"""

helps['ppg list'] = """
type: command
short-summary: List proximity placement groups
examples:
- name: List proximity placement groups (autogenerated)
text: |
az ppg list --resource-group MyResourceGroup
crafted: true
"""

helps['ppg update'] = """
type: command
short-summary: Update a proximity placement group
parameters:
- name: --include-colocation-status
short-summary: includeColocationStatus=true enables fetching the colocation status of all the resources in the
proximity placement group. Default value is None.
examples:
- name: Update a proximity placement group with specifying VM sizes that can be created.
text: |
az ppg update --name MyProximityPlacementGroup --resource-group MyResourceGroup \\
--intent-vm-sizes Standard_E64s_v4 Standard_M416ms_v2
"""

helps['sig image-definition create'] = """
type: command
short-summary: create a gallery image definition
Expand Down
13 changes: 0 additions & 13 deletions src/azure-cli/azure/cli/command_modules/vm/_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -1408,19 +1408,6 @@ def load_arguments(self, _):

# endregion

# region Proximity Placement Group
with self.argument_context('ppg', min_api='2018-04-01') as c:
c.argument('proximity_placement_group_name', arg_type=name_arg_type, help="The name of the proximity placement group.")

with self.argument_context('ppg create') as c:
c.argument('tags', tags_type, min_api='2018-04-01')
c.argument('zone', zone_type, min_api='2021-11-01')

for scope in ['ppg create', 'ppg update']:
with self.argument_context(scope) as c:
c.argument('ppg_type', options_list=['--type', '-t'], arg_type=get_enum_type(self.get_models('ProximityPlacementGroupType')), min_api='2018-04-01', help="The type of the proximity placement group.")
c.argument('intent_vm_sizes', nargs='*', min_api='2021-11-01', help="Specify possible sizes of virtual machines that can be created in the proximity placement group.")

with self.argument_context('vm create', min_api='2018-04-01') as c:
c.argument('proximity_placement_group', options_list=['--ppg'], help="The name or ID of the proximity placement group the VM should be associated with.",
validator=_validate_proximity_placement_group)
Expand Down
10 changes: 0 additions & 10 deletions src/azure-cli/azure/cli/command_modules/vm/_validators.py
Original file line number Diff line number Diff line change
Expand Up @@ -2445,16 +2445,6 @@ def _disk_encryption_set_format(cmd, namespace, name):
# endregion


def process_ppg_create_namespace(namespace):
validate_tags(namespace)
# The availability zone can be provided only when an intent is provided
if namespace.zone and not namespace.intent_vm_sizes:
raise RequiredArgumentMissingError('The --zone can be provided only when an intent is provided. '
'Please use parameter --intent-vm-sizes to specify possible sizes of '
'virtual machines that can be created in the proximity placement group.')
# endregion


def process_image_version_create_namespace(cmd, namespace):
validate_tags(namespace)
process_gallery_image_version_namespace(cmd, namespace)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,8 @@
# flake8: noqa

from .__cmd_group import *
from ._create import *
from ._delete import *
from ._list import *
from ._show import *
from ._update import *
Loading