Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new): Azure Data Explorer #308

Closed
wants to merge 37 commits into from

Conversation

dciborow
Copy link
Contributor

@dciborow dciborow commented Apr 7, 2023

Closes #287

Description

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, edit the PR description and run through the relevant checklist below.

Enable GitHub Worksflows in your fork to enable auto-generation of assets with our GitHub Action.
To trigger GitHub Actions after auto-generation, add a GitHub PAT as a secret in your forked repository called PAT.

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

@dciborow dciborow changed the title add event hub and cosmosdb with tests [Module Proposal]: Azure Data Explorer Clusters Apr 7, 2023
@dciborow dciborow changed the title [Module Proposal]: Azure Data Explorer Clusters feat Azure Data Explorer Clusters Apr 7, 2023
@dciborow dciborow changed the title feat Azure Data Explorer Clusters feat: Azure Data Explorer Clusters Apr 7, 2023
@dciborow dciborow self-assigned this Apr 7, 2023
@dciborow dciborow changed the title feat: Azure Data Explorer Clusters feat: new Azure Data Explorer Module Apr 7, 2023
@dciborow
Copy link
Contributor Author

dciborow commented Apr 8, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shenglol
Copy link
Contributor

shenglol commented Apr 8, 2023

@dciborow I added a comment about the path here #287 (comment). What do you think?

@dciborow dciborow changed the title feat: new Azure Data Explorer Module feat(new): Azure Data Explorer Apr 17, 2023
@dciborow dciborow requested a review from a team as a code owner May 9, 2023 17:20
@dciborow dciborow changed the base branch from main to dciborow/gpt-review May 15, 2023 21:46
@ChrisSidebotham
Copy link
Contributor

Dear @dciborow , Azure Verified Modules (AVM) will become the single Microsoft standard for Bicep modules. Transitioning to AVM, requests for new features or bug fixes will need to be submitted against the appropriate AVM module via AVM Module Issues.

For bugs or new features with existing modules in the /modules directory of this repository, we encourage you to first try the AVM equivalent module if available and if the module is lacking any features, you can file an AVM Module Issue. If the module is not available yet, you can file a new AVM Module Proposal.

See this informational notice for more details on the upcoming changes.

Thank you for your understanding!

Note

The "Type: AVM 🅰️ ✌️ Ⓜ️" label was added as per ITA08BCP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Module Proposal]: Azure Data Explorer Clusters [Kusto/clusters]
3 participants