Implementation of call feature streams Support #5241
Conversation
…treams that is not tied to participant
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-aodkuihnvy.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-huocwmgaga.chromatic.com/ |
cn0151
added
breaking-change
does not need changelog
Chat bundle size is not changed.
|
CallWithChat bundle size is not changed.
|
Calling bundle size is not changed.
|
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-fdigliyicb.chromatic.com/ |
cn0151
changed the title
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-mizzdumluh.chromatic.com/ |
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
cn0151
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
PorterNan,
mgamis-msft and
prabhjot-msft
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-wxlnmermlm.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-tuppniffwu.chromatic.com/ |
|
Hey @cn0151 Can you please add a changelog to this PR? if there are API changes there should always be one. |
cn0151
removed
the
does not need changelog
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-jbgwkmrxhv.chromatic.com/ |
packages/calling-component-bindings/src/handlers/createCommonHandlers.ts
Outdated
Show resolved
Hide resolved
| * @beta | ||
| */ | ||
| export interface TogetherModeSeatingCoordinatesState { | ||
| // the y coordinate of the participant seating position in the together mode stream |
There was a problem hiding this comment.
Can we denote here which corner of the bounding box this will be?
There was a problem hiding this comment.
I'm guessing top left
| @@ -457,11 +459,25 @@ export class CallContext { | |||
| } | |||
|
|
|||
| /* @conditional-compile-remove(together-mode) */ | |||
| public setTogetherModeVideoStream(callId: string, addedStream: TogetherModeVideoStream[]): void { | |||
| public setTogetherModeVideoStream(callId: string, addedStreams: TogetherModeVideoStream[]): void { | |||
There was a problem hiding this comment.
Again, can we have this an an object for the TogetherModeVideoStream instead of an array?
There was a problem hiding this comment.
This method is internal and the TogetherModeVideoStream array is from SDK. Also I was referencing what was done for the setCallRemoteParticipants method
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-jdgfzjspwa.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-oaiuiomioa.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-lhzvsbvkgk.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-raepicvnll.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-seecxzowzq.chromatic.com/ |
…github.com/Azure/communication-ui-library into cnwankwo/callFeatureStreams_implementation
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ukzmjjsjyf.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ebrqtadwqd.chromatic.com/ |
What
The PR contains the implementation to render streams that are not tied to a participant or device Manager. it also contains seat map updates to together mode stream state.
Why
This resolves the issue where we want to render a call feature stream that is not tied to a participant
How Tested
Process & policy checklist
Is this a breaking change?