Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of call feature streams Support #5241
base: main
Are you sure you want to change the base?
Implementation of call feature streams Support #5241
Changes from 16 commits
27492b0
723da07
6f0c40d
4e95fed
f0a2396
9985249
ea8d7fa
8bd4960
d1c525a
cd62937
bf66778
1354911
87c7d45
3b61bad
ecb470d
3abfd2d
46d2d8f
8601b16
ce9cb8d
87e9def
863f722
e04a9ca
03e0f8f
6bf4544
a931f58
37e426f
91f4321
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we denote here which corner of the bounding box this will be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing top left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, can we have this an an object for the TogetherModeVideoStream instead of an array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is internal and the TogetherModeVideoStream array is from SDK. Also I was referencing what was done for the setCallRemoteParticipants method