Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix locale string typo for captions dropdown. Fix usePropsFor return type for RaisedHandButton #5448

Merged
merged 15 commits into from
Nov 29, 2024
Merged

Fix locale string typo for captions dropdown. Fix usePropsFor return type for RaisedHandButton #5448

merged 15 commits into from
Nov 29, 2024

Conversation

mgamis-msft
Copy link
Contributor

What

  • Fix locale string typo for captions dropdown info
  • Fix usePropsFor return type for RaisedHandButton

Why

#5443

How Tested

Tested locally that string is correct in composite and raised hand button works as before

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@mgamis-msft mgamis-msft requested review from a team as code owners November 27, 2024 23:04
@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@mgamis-msft mgamis-msft mentioned this pull request Nov 27, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ykdjpivcaq.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 27, 2024 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26968 / 43514
61.97%		 26968 / 43514
61.97%		 735 / 1355
54.24%		 2161 / 3483
62.04%
Current 26976 / 43514
61.99%		 26976 / 43514
61.99%		 735 / 1355
54.24%		 2165 / 3485
62.12%
Diff 8 / 0
0.02%		 8 / 0
0.02%		 0 / 0
0%		 4 / 2
0.08%

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 27, 2024 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 54644 / 90430
60.42%		 54644 / 90430
60.42%		 1107 / 2574
43%		 3231 / 5391
59.93%
Current 54666 / 90432
60.44%		 54666 / 90432
60.44%		 1107 / 2574
43%		 3241 / 5392
60.1%
Diff 22 / 2
0.02%		 22 / 2
0.02%		 0 / 0
0%		 10 / 1
0.17%

@mgamis-msft mgamis-msft added the update_snapshots Set this label to request automated update of UI snapshots label Nov 28, 2024
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Nov 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-agwfeddhdb.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

JamesBurnside
JamesBurnside reviewed Nov 28, 2024
View reviewed changes
...text-edit-box-not-empty-message-content-without-attachment-Mobile-Android-Portrait-linux.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a bug on this, can you revert from this PR?

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-qijcgiajqz.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is decreased✅.

  • Current size: 1762308
  • Base size: 1762309
  • Diff size: -1

@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 11767065
  • Base size: 11767065
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 11767078
  • Base size: 11767078
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-olxylkfgms.chromatic.com/

@mgamis-msft mgamis-msft merged commit 51adc09 into main Nov 29, 2024
41 checks passed
@mgamis-msft mgamis-msft deleted the mgamis/fix-locale-string-typo-and-raise-button-usePropsFor-typing branch November 29, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesBurnside JamesBurnside JamesBurnside approved these changes

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@dmceachernmsft dmceachernmsft

@edwardlee-msft edwardlee-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgamis-msft @JamesBurnside @dmceachernmsft @edwardlee-msft