-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix locale string typo for captions dropdown. Fix usePropsFor return type for RaisedHandButton #5448
Merged
mgamis-msft
merged 15 commits into
main
from
mgamis/fix-locale-string-typo-and-raise-button-usePropsFor-typing
Nov 29, 2024
Merged
Fix locale string typo for captions dropdown. Fix usePropsFor return type for RaisedHandButton #5448
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
037d3bc
Fix string type for captions dropdown info. Fix usePropsFor return ty…
mgamis-msft 274dabf
api changes
mgamis-msft 792e7a3
Change files
mgamis-msft 5700704
remove console log
mgamis-msft 6a48262
Update packages/react-components browser test snapshots
github-actions[bot] baed8f5
Update packages/react-composites CallWithChatComposite browser test s…
github-actions[bot] 3805066
Merge branch 'mgamis/fix-locale-string-typo-and-raise-button-useProps…
github-actions[bot] cfdc221
Update packages/react-composites CallWithChatComposite browser test s…
github-actions[bot] ed75982
Merge branch 'mgamis/fix-locale-string-typo-and-raise-button-useProps…
github-actions[bot] 80b8230
Update packages/react-composites CallComposite browser test snapshots
github-actions[bot] 08bfbf5
Merge branch 'mgamis/fix-locale-string-typo-and-raise-button-useProps…
github-actions[bot] e9328e7
Update packages/react-composites CallComposite browser test snapshots
github-actions[bot] 1bd916b
Merge branch 'mgamis/fix-locale-string-typo-and-raise-button-useProps…
github-actions[bot] 05fa3cd
revert flakey snapshot update
mgamis-msft 31a02b8
Merge branch 'main' into mgamis/fix-locale-string-typo-and-raise-butt…
mgamis-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
9 changes: 9 additions & 0 deletions
9
change-beta/@azure-communication-react-a67a4239-b169-42a1-a80e-e4283bad5628.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"type": "minor", | ||
"area": "fix", | ||
"workstream": "Captions and Raised hands", | ||
"comment": "Fix string typo for captions dropdown info. Fix usePropsFor return type for RaiseHandButton.", | ||
"packageName": "@azure/communication-react", | ||
"email": "[email protected]", | ||
"dependentChangeType": "patch" | ||
} |
9 changes: 9 additions & 0 deletions
9
change/@azure-communication-react-a67a4239-b169-42a1-a80e-e4283bad5628.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"type": "minor", | ||
"area": "fix", | ||
"workstream": "Captions and Raised hands", | ||
"comment": "Fix string typo for captions dropdown info. Fix usePropsFor return type for RaiseHandButton.", | ||
"packageName": "@azure/communication-react", | ||
"email": "[email protected]", | ||
"dependentChangeType": "patch" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+1.94 KB
(200%)
...-not-empty-message-content-without-attachment-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-154 Bytes
(100%)
...losedCaptions.test.ts-snapshots/teams-caption-settings-Desktop-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-154 Bytes
(100%)
...-snapshots/trigger-teams-captions-settings-from-banner-Desktop-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-179 Bytes
(100%)
...-snapshots/trigger-teams-captions-settings-from-banner-Desktop-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-154 Bytes
(100%)
...losedCaptions.test.ts-snapshots/teams-caption-settings-Desktop-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-154 Bytes
(100%)
...-snapshots/trigger-teams-captions-settings-from-banner-Desktop-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-179 Bytes
(100%)
...-snapshots/trigger-teams-captions-settings-from-banner-Desktop-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a bug on this, can you revert from this PR?