Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Node versions for Web UI library #5589

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Updated Node versions for Web UI library #5589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bde78be
Updated Node versions for Web UI library
vhuseinova-msft Jan 28, 2025
5ef321f
Merge remote-tracking branch 'origin/main' into vhuseinova/node-versi…
vhuseinova-msft Jan 28, 2025
1cf3065
Test update
vhuseinova-msft Jan 29, 2025
54e2057
Merge branch 'main' into vhuseinova/node-version-update
vhuseinova-msft Jan 29, 2025
18e74ee
Merge branch 'main' into vhuseinova/node-version-update
vhuseinova-msft Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/alpha-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move this to be a Github variable like the ubuntu version in case we need to change it?

Copy link
Member Author

@vhuseinova-msft vhuseinova-msft Jan 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could but we already have been using LTS in some of the pipelines.

One of the advantages of using LTS is that the Node.js version will automatically migrate as LTS roles change. This ensures that the version won't be forgotten, reducing the need for manual updates. Also node is usually pretty good with backward compatibility (and deprecation policies) and has predictable release schedule


# Try get node_modules from cache
- name: Restore node_modules from cache
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/create-api-view-feature-level.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:
with:
fetch-depth: 0
# Ensure node version is great enough
- name: Use Node.js v20.x
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
# Install dependencies
- name: Install rush
run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create-prerelease-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'

# Try get node_modules from cache
- name: Restore node_modules from cache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create-release-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'

# Make sure that Rush is installed in run
- name: Add rush to run
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-azure-webapps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Use Node.js 20.x
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 20.x
node-version: 'lts/*'

- name: Restore node_modules from cache
uses: actions/cache@v4
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/deploy-feature-azure-webapps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Install rush
run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
- name: Install dependencies
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Install rush
run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
- name: Install dependencies
Expand Down Expand Up @@ -110,7 +110,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Install rush
run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
- name: Install dependencies
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/deploy-release-azure-webapps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Install rush
run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
- name: Install dependencies
Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Install rush
run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
- name: Install dependencies
Expand Down Expand Up @@ -126,7 +126,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Install rush
run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
- name: Install dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy-storybook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Use Node.js 20.x
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 20.x
node-version: 'lts/*'

- name: Restore node_modules from cache
uses: actions/cache@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'

# Try get node_modules from cache
- name: Restore node_modules from cache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/npm-release-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'

# Install dependencies
- name: Install rush
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-chromatic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ jobs:
with:
fetch-depth: 0

- name: Use Node.js 20.x
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 20.x
node-version: 'lts/*'

- name: Restore node_modules from cache
uses: actions/cache@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stress-test-ui-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Restore node_modules from cache
uses: actions/cache@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-api-files.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
# Try get node_modules from cache
- name: Restore node_modules from cache
uses: actions/cache@v4
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/update-chat-snapshots.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Use Node.js v20.x
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- id: get-matrix
run: echo "matrix=$(node ./common/scripts/workflow-read-matrix.mjs)" >> $GITHUB_OUTPUT

Expand Down Expand Up @@ -82,10 +82,10 @@ jobs:
run: |
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
git config user.name "github-actions[bot]"
- name: Use Node.js v20.x
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Install rush
run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
- name: Install dependencies
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/update-snapshots.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- id: get-matrix
run: echo "matrix=$(node ./common/scripts/workflow-read-matrix.mjs)" >> $GITHUB_OUTPUT

Expand Down Expand Up @@ -90,7 +90,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Restore node_modules from cache
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -186,7 +186,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Restore node_modules from cache
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -282,7 +282,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Restore node_modules from cache
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -378,7 +378,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Restore node_modules from cache
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -474,7 +474,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Restore node_modules from cache
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -570,7 +570,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 'lts/*'
- name: Restore node_modules from cache
uses: actions/cache@v4
with:
Expand Down
4 changes: 2 additions & 2 deletions ...react-components/tests/browser/FluentChatMessageComponentKeyboardNavigationTests.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ betaTest.describe('FluentChatMessageComponent keyboard navigation tests', () =>

betaTest('User can navigate to message using keyboard', async ({ mount, page }) => {
const component = await mount(<FluentChatMessageComponent {...props} />);
const messageBody = component.getByTestId('chat-composite-message');
await messageBody.waitFor({ state: 'visible' });

await page.keyboard.press('Tab');
const messageBody = component.getByTestId('chat-composite-message');
await expect(messageBody).toBeVisible();
await expect(messageBody).toBeFocused();

// check that focus stays on the message and not moved anywhere after additional Enter key press
Expand Down