Updated Node versions for Web UI library #5589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhuseinova-msft
added
the
does not need changelog
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
vhuseinova-msft
added
the
update_snapshots
github-actions
bot
removed
the
update_snapshots
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-qqbzpbpsxj.chromatic.com/ |
vhuseinova-msft
temporarily deployed
to
production
GitHub Actions
Inactive
vhuseinova-msft
temporarily deployed
to
production
GitHub Actions
Inactive
vhuseinova-msft
temporarily deployed
to
production
GitHub Actions
Inactive
vhuseinova-msft
temporarily deployed
to
npm-alpha
GitHub Actions
Inactive
vhuseinova-msft
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft,
jimchou-dev and
Leah-Xia-Microsoft
vhuseinova-msft
requested review from
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
emlynmac
approved these changes
Jan 29, 2025
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-hiylpjmstz.chromatic.com/ |
edwardlee-msft
approved these changes
Jan 29, 2025
dmceachernmsft
approved these changes
Jan 29, 2025
| @@ -28,7 +28,7 @@ jobs: | |||
| - name: Use Node.js | |||
| uses: actions/setup-node@v4 | |||
| with: | |||
| node-version: '20.x' | |||
| node-version: 'lts/*' | |||
There was a problem hiding this comment.
should we move this to be a Github variable like the ubuntu version in case we need to change it?
There was a problem hiding this comment.
We could but we already have been using LTS in some of the pipelines.
One of the advantages of using LTS is that the Node.js version will automatically migrate as LTS roles change. This ensures that the version won't be forgotten, reducing the need for manual updates. Also node is usually pretty good with backward compatibility (and deprecation policies) and has predictable release schedule
Calling bundle size is not changed.
|
Chat bundle size is decreased✅.
|
CallWithChat bundle size is not changed.
|
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-jxtaxflqiw.chromatic.com/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
How Tested
Run most of the GitHub workflows
Process & policy checklist
Is this a breaking change?