Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update download Module to Process Data by Laboratory COD and Project Subfolder #431

Merged
merged 8 commits into from
Mar 17, 2025
Merged

Update download Module to Process Data by Laboratory COD and Project Subfolder #431

merged 8 commits into from
Mar 17, 2025

Conversation

Aberdur
Copy link
Contributor

@Aberdur Aberdur commented Mar 13, 2025

PR Description

This PR modifies the download module to ensure that downloads and folder cleanup for the options download_only, download_clean, and delete_only are now performed at the project folder level.

Changes:

  • Updated the logic for downloading, cleaning, and deleting files to operate at the project directory level instead of broader directory structures.
  • Ensured that all three options (download_only, download_clean, and delete_only) consistently follow this new behavior.
  • Improved handling of project-specific data organization to enhance clarity and prevent unintended data modifications.

@Aberdur Aberdur self-assigned this Mar 13, 2025
@Aberdur Aberdur marked this pull request as draft March 13, 2025 15:14
@Aberdur Aberdur linked an issue Mar 13, 2025 that may be closed by this pull request
Implement Project-Level Directory Processing in download Module #428
Closed
@Aberdur Aberdur marked this pull request as ready for review March 13, 2025 16:19
Shettland
Shettland approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@Shettland Shettland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aberdur Aberdur merged commit d679f2f into BU-ISCIII:develop Mar 17, 2025
17 checks passed
@Aberdur Aberdur linked an issue Mar 18, 2025 that may be closed by this pull request
Ensure Proper Mapping of %LDMutations Between File and Configuration #432
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shettland Shettland Shettland approved these changes

Assignees

@Aberdur Aberdur

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Aberdur @Shettland