Fix adding_ontology_to_enum when enum has no ontology #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shettland
reviewed
Mar 19, 2025
Shettland
reviewed
Mar 19, 2025
|
I'd rather check the schema before running the module rather than checking if properties are dicts or enums are lists because that would mean that the provided schema is not correctly built |
Shettland
reviewed
Mar 19, 2025
Shettland
reviewed
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
As it is right now
read-lab-metadataif the value has no ontology the module tries to add it. But it does this all the time and fails when the enum has no ontology and tries to add one (which it doesn't have).