NW | ITP_MAY_25 | Nor_ZEHHAF | Wireframe_to_Webcode #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
illicitonion
added
Review in progress
There was a problem hiding this comment.
In terms of layout, this page doesn't quite match the wireframe. A few things:
- The title and short description are meant to be centred, and the short description should probably be shorter.
- I expect some empty space around the three articles, right now they take up the whole width of the page.
- The git image is very large, and makes the page hard to interact with.
- I ran lighthouse on this page and it didn't score 100.
| <h3>Branches in Git</h3> | ||
| <address> | ||
| Written by a shared effort, | ||
| <time datetime="2025-05-09">on 2025/05/09</time> |
There was a problem hiding this comment.
A time of writing doesn't feel like it belongs in an <address> tag - can you think of a more suitable tag to use for this information?
(This applies to all three articles)
| --font: 100%/1.5 system-ui; | ||
| --space: clamp(6px, 6px + 2vw, 15px); | ||
| --line: 1px solid; | ||
| --container: 1280px; | ||
| --container: 1250; |
There was a problem hiding this comment.
What are the units of this value?
| body { | ||
| background: var(--paper); | ||
| color: var(--ink); | ||
| color: var(--ink); |
There was a problem hiding this comment.
Try to avoid adding trailing space where it's not needed.
| </footer> | ||
| Branching in Git is a powerful feature that allows developers to diverge from the main codebase and work on new features, bug fixes, or experiments in isolation. By creating a separate branch, you can make changes without affecting the stable version of your project, enabling parallel development and smoother collaboration among team members. This article explores how branching works in Git, why it's essential in modern version control workflows, and how to effectively use branches to manage your code with confidence and flexibility.</p> <a href="https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell">Read more</a> | ||
| </article> | ||
| <article id="second_article_wrap"> |
There was a problem hiding this comment.
Why don't the second and third articles have images?
illicitonion
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.