Skip to content

NW | ITP_MAY_25 | Nor_ZEHHAF | Wireframe_to_Webcode #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 44 additions & 22 deletions Wireframe/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,27 +7,49 @@
<link rel="stylesheet" href="style.css" />
</head>
<body>
<header>
<h1>Wireframe</h1>
<p>
This is the default, provided code and no changes have been made yet.
</p>
</header>
<main>
<article>
<img src="placeholder.svg" alt="" />
<h2>Title</h2>
<header>
<h1>
THIS IS A TITLE
</h1>
<p>
This is a template webpage for the first sprint of the onboarding module backlog.<br> It contains three articles exploring fundemental development concepts: the purpose of README files in the documentation, why are wireframes useful in the design process, and how git branches function in version control systems.<br>All of which are considered fundemental knowledge for web developement and collaborative project workflows.
</p>
</header>
<main>
<article id="first_article_wrap">
<img src="https://git-scm.com/book/en/v2/images/basic-merging-1.png">
<h3>Branches in Git</h3>
<address>
Written by a shared effort,
<time datetime="2025-05-09">on 2025/05/09</time>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A time of writing doesn't feel like it belongs in an <address> tag - can you think of a more suitable tag to use for this information?

(This applies to all three articles)

</address>
<p>
Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam,
voluptates. Quisquam, voluptates.
</p>
<a href="">Read more</a>
</article>
</main>
<footer>
<p>
This is the default, provided code and no changes have been made yet.
</p>
</footer>
Branching in Git is a powerful feature that allows developers to diverge from the main codebase and work on new features, bug fixes, or experiments in isolation. By creating a separate branch, you can make changes without affecting the stable version of your project, enabling parallel development and smoother collaboration among team members. This article explores how branching works in Git, why it's essential in modern version control workflows, and how to effectively use branches to manage your code with confidence and flexibility.</p> <a href="https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell">Read more</a>
</article>
<article id="second_article_wrap">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't the second and third articles have images?

<h3>README files</h3>
<address>
Written by a shared effort,
<time datetime="2025-05-09">on 2025/05/09</time>
</address>
<p>
README files are the cornerstone of good project documentation, offering a clear and concise introduction to a codebase or repository. Typically placed at the root of a project, a README serves as the first point of contact for users and contributors, outlining the project's purpose, installation steps, usage instructions, and other essential information. In this article, we'll explore the role of README files in software documentation, what makes an effective README, and how to craft one that improves user experience and encourages community engagement.
</p><a href="https://deploybot.com/blog/the-power-of-readme-files-a-must-have-for-every-repository#:~:text=A%20README%20file%20serves%20as%20your%20repository%27s%20welcome,project%27s%20purpose%2C%20functionality%2C%20and%20how%20to%20use%20it.">Read more</a>
</article>
<article id="third_article_wrap">
<h3>Purpose of wireframes</h3>
<address>
Written by a shared effort,
<time datetime="2025-05-09">on 2025/05/09</time>
</address>
<p>
Wireframes are a foundational tool in the design process, serving as visual blueprints that outline the structure and layout of a digital product before any detailed design or development begins. By focusing on functionality, content placement, and user flow—without the distraction of colors or final graphics—wireframes help teams align on the user experience early on. In this article, we’ll examine the purpose of wireframes, how they facilitate collaboration between designers, developers, and stakeholders, and why they are essential for building intuitive and user-friendly interfaces.
</p> <a href="https://protoio.medium.com/why-wireframes-are-important-in-the-design-process-de4e773e611">Read more</a>
</article>

</main>
<footer>
<p>© CYF | ITP May-25 | Nor ZEHHAF</p>
</footer>
</body>
</html>
</html>
33 changes: 19 additions & 14 deletions Wireframe/style.css
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
/* Here are some starter styles
You can edit these or replace them entirely
It's showing you a common way to organise CSS
And includes solutions to common problems
As well as useful links to learn more */

/* ====== Design Palette ======
This is our "design palette".
It sets out the colours, fonts, styles etc to be used in this design
Expand All @@ -17,18 +11,25 @@ As well as useful links to learn more */
https://scrimba.com/learn-css-variables-c026
====== Design Palette ====== */
:root {
--paper: oklch(7 0 0);
--ink: color-mix(in oklab, var(--color) 5%, black);
--paper: RGB(187, 187, 187);
--paper_main: RGB(136, 136, 136);
--ink: RGB(0, 0, 0);
--font: 100%/1.5 system-ui;
--space: clamp(6px, 6px + 2vw, 15px);
--line: 1px solid;
--container: 1280px;
--container: 1250;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the units of this value?

}
/* ====== Base Elements ======
General rules for basic HTML elements in any context */
header{
background: var(--paper_main);
max-width: var(--container);
margin: 0 auto calc(var(--space) * 4) auto;

}
body {
background: var(--paper);
color: var(--ink);
color: var(--ink);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to avoid adding trailing space where it's not needed.

font: var(--font);
}
a {
Expand All @@ -39,7 +40,7 @@ a {
img,
svg {
width: 100%;
object-fit: cover;
object-fit: scale-down;
}
/* ====== Site Layout ======
Setting the overall rules for page regions
Expand All @@ -50,9 +51,13 @@ main {
margin: 0 auto calc(var(--space) * 4) auto;
}
footer {
position: fixed;
bottom: 0;
background: var(--paper_main);
text-align: center;
position: fixed;
width: 100%;
bottom: 0px;
left: 0px;

}
/* ====== Articles Grid Layout ====
Setting the rules for how articles are placed in the main element.
Expand Down Expand Up @@ -86,4 +91,4 @@ article {
> img {
grid-column: span 3;
}
}
}