CYF - South Africa | Jordy Mukandayi | Module-User Focused-Data | Wireframe | Week 1 #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-ufd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Wireframe/css/style.css
Outdated
There was a problem hiding this comment.
good job. However, it is better to use responsive units like REM and % in your css to make it better for mobile.
There was a problem hiding this comment.
Thank I have added % in my css for responsive to make it easy for mobile devise users.
Wireframe/index.html
Outdated
| @@ -4,10 +4,46 @@ | |||
| <meta charset="UTF-8"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
| <title>Wireframe</title> | |||
There was a problem hiding this comment.
It would be better to use a better more descriptive title.
There was a problem hiding this comment.
I change Wireframe to GitHub Tutorial
Waldo-Strydom
added
Reviewed
|
the Wireframe become responsive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.