Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYF - South Africa | Jordy Mukandayi | Module-User Focused-Data | Wireframe | Week 1 #326

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 109 additions & 0 deletions Wireframe/css/style.css

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job. However, it is better to use responsive units like REM and % in your css to make it better for mobile.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank I have added % in my css for responsive to make it easy for mobile devise users.

Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
body{
margin: 0;
padding: 0;
display: inline;
font-family: "Manrope", sans-serif;
font-size: 15px;
width: 500px;
}
#git-header{
display: flex;
flex-direction: column;
align-items: center;
}
/* What is Git style*/
.what-git{
display: flex;
flex-direction: column;
align-items: center;
padding: 20px;
background: #f7f7f5;
}
.git-img{
width: 800px;
margin: 5px auto 20px auto;
}
.box-git{
margin-left: -255px;
margin-bottom: 1px;
}
h2{
font-size: 30px;
}
p{
font-size: 20px;
}
.btn{
display: inline-block;
border-radius: 4px;
background-color: #f4511e;
border: none;
text-align: center;
font-size: 20px;
padding: 10px;
margin-right: 690px;
}
a{
text-decoration: none;
color: #ffffff;
}
.btn:hover{
padding-right: 25px;
transition: 0.5;
background-color: #f48c06;
}
/* Section Why do developers need Git? */
#git-section{
display: flex;
justify-content: center;
margin: 10px auto 50px auto;
padding: 10px;
width: 400px;
}
.img-section{
margin-left: 2px;
padding: 0 6px;
width: 400px;
}
.branch-float{
margin-left: 15px;
margin-right: 30px;
}
h3{
font-size: 15px;
display: flex;
justify-content: left;
}
.paragragh{
float: left;
font-size: 12px;
width:300px;
}
.btn-2{
display: inline-block;
border-radius: 4px;
background-color: #f4511e;
border: none;
color: #ffffff;
text-align: center;
font-size: 28px;
padding: 10px;
cursor: pointer;
}
/* What is a branch in Git */
.why-git{
padding: 20px;
margin-top: 10px;
}
.why-git-2{
display: block;
margin-top: 30px;
}
/* Footer */
.footer{
display: flex;
justify-content: center;
font-style: italic;
background: #f4511e;
color: white;
}
Binary file added Wireframe/img/git.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Wireframe/img/git2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Wireframe/img/github-img.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Wireframe/img/github.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
38 changes: 37 additions & 1 deletion Wireframe/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,46 @@
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Wireframe</title>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to use a better more descriptive title.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I change Wireframe to GitHub Tutorial

<link rel="stylesheet" href="style.css">
<link rel="stylesheet" href="css/style.css">
</head>
<body>
<!-- Add your HTML markup here -->
<!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc -->
<header id="git-header">
<h1>GitHub</h1>
<p>Git is Version Control Software</p>
</header>
<!-- What is Git Section -->
<section class="what-git">
<img class="git-img" src="img/github-img.jpg"/>
<div class="box-git">
<h2>What is Git?</h2>
<p>Git is a distributed version control system<br>
that allows developers to track changes made in their code</p>
</div>
<button class="btn"><a href="https://www.atlassian.com/git/tutorials/what-is-git" target="_blank">Read More</a></button>
</section>
<section id="git-section">
<div class="why-git">
<img class="img-section" src="img/git.png">
<div class="branch-float">
<h3>Why do developers need Git?</h3>
<p class="paragragh">Developers need Git for several reasons: Git keeps a history of changes made to the codebase</p>
<button class="btn-2"><a href="" target="_blank">Read More</a></button>
</div>
</div>
<div class="why-git-2">
<img class="img-section" src="img/git2.png">
<div class="branch-float">
<h3>What is a branch in Git?</h3>
<p class="paragragh">A branch in Git is essentially a pointer to a specific commit in the repository's history</p>
<button class="btn-2"><a href="https://www.w3schools.com/git/git_branch.asp" target="_blank">Read More</a></button>
</div>
</div>
</section>
<footer class="footer">
<p>Copyright 2024 - Made by Jordy Mukandayi</p>

</footer>
</body>
</html