Skip to content

misc bug fixes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

misc bug fixes #2

wants to merge 6 commits into from

Conversation

KolzeYT
Copy link
Contributor

@KolzeYT KolzeYT commented Jun 16, 2025

No description provided.

@NexIsDumb NexIsDumb requested a review from lunarcleint July 6, 2025 16:16
@Circuitella
Copy link

antialiasing by default would fuck so many things in just 1 mod alone that i work on

@KolzeYT
Copy link
Contributor Author

KolzeYT commented Jul 16, 2025

antialiasing by default would fuck so many things in just 1 mod alone that i work on

it was only for the stage editor cuz it for some reason was off when making a new sprite

Raltyro pushed a commit that referenced this pull request Jul 19, 2025
* vanilla num1 update (#1)

* Updated vanilla num1 to match up with latest game update (Post-Vslice)
(FUNKIN ART STYLE)

* vanilla num1 update (#2)

* Updated vanilla num1 to match up with latest game update (Post-Vslice)
(PIXEL ART STYLE)
@KolzeYT
Copy link
Contributor Author

KolzeYT commented Jul 27, 2025

what the fuck

@Frakits
Copy link
Member

Frakits commented Jul 27, 2025

dude? 😭

@KolzeYT
Copy link
Contributor Author

KolzeYT commented Jul 27, 2025

miss click

@KolzeYT KolzeYT changed the base branch from new-editors to main July 27, 2025 12:19
@KolzeYT
Copy link
Contributor Author

KolzeYT commented Jul 27, 2025

fixed it

@KolzeYT KolzeYT changed the title fixed game crashing when changing the stage in the chart editor + antialiasing on by default when making a new sprite misc bug fixes Jul 27, 2025
@@ -395,6 +395,7 @@ class StageEditor extends UIState {
char.extra.set(exID("parentNode"), parent);
char.extra.set(exID("highMemory"), parent.name == "highMemory");
char.extra.set(exID("lowMemory"), parent.name == "lowMemory");
char.scale.x = node.has.scalex ? Std.parseFloat(node.att.scalex) : 1;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no char.scale.y too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason scale y works fine

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im gonna check later whats causing this

@@ -76,8 +76,6 @@ class ChartDataScreen extends UISubstateWindow {
}

public function saveInfo() {
UIUtil.confirmUISelections(this);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be kept

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should it just crashed the game when i made this pull request (i know it was a really bad solution to the problem)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants