Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create uk_ua.json #42

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Create uk_ua.json #42

merged 1 commit into from
Aug 10, 2023

Conversation

unroman
Copy link
Contributor

@unroman unroman commented Aug 2, 2023

Ukrainian grammar doesn't allow me to make a better translation, but I also can't add exceptions to the translation myself, something like "architecture_extensions.minecrafr.end_stone_arch": "..."

maybe in the future, when I figure out how to add exceptions, I'll come back and do a better translation

Ukrainian grammar doesn't allow me to make a better translation, but I also can't add exceptions to the translation myself, something like "architecture_extensions.minecrafr.end_stone_arch": "..."

maybe in the future, when I figure out how to add exceptions, I'll come back and do a better translation
@woodiertexas
Copy link
Collaborator

What do you mean by "exceptions"?

@falkreon
Copy link
Member

falkreon commented Aug 2, 2023

Am I correct in understanding that in some cases the best translation would be <adjective> <noun> <adjective> like your endstone nubless rod translation? If so, I agree, exceptions would be a good workaround. We should have an update soon to make that possible.

@unroman
Copy link
Contributor Author

unroman commented Aug 3, 2023

@falkreon In fact, it's not so simple, some blocks have several words in their name, which is why they cannot be placed in front, as it happens in English, because in most Slavic languages, each word has a special ending that depends on the final word and therefore most translations should sound like «Arch from cracked stone bricks» — «Дуга з тріснутої кам'яної цегли» <noun> <adjective> <adjective> <noun>

@unroman
Copy link
Contributor Author

unroman commented Aug 3, 2023

when it comes to one word, it's very easy to do because I do it through combinations
Bamboo - «Бамбуков», Arch - «а дуга» = «Бамбукова дуга»

@falkreon
Copy link
Member

falkreon commented Aug 3, 2023

I see. I just wanted to understand the problem so I don't make the same mistake again in another mod. We'll get you the tools you need.

@falkreon
Copy link
Member

falkreon commented Aug 5, 2023

Overrides work now - but I highly recommend keeping these best-effort individual keys around for compatibility with serverside things like Polydex.

Overrides are keyed on the "default" localization key that Minecraft would have generated for these blocks. So if the F3+H tooltip shows architecture_extensions:minecraft/end_stone_arch, the override localization key would be block.architecture_extensions.minecraft.end_stone_arch

Hope that helps! If you aren't feeling like adding additional translations right this second though we can go ahead and merge what you've put here.

@woodiertexas woodiertexas merged commit 6a94e73 into DebuggyTeam:1.20 Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants