Localization and meta-blocktypes #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximumpower55
approved these changes
Aug 4, 2023
src/main/java/io/github/debuggyteam/architecture_extensions/TypedGroupedBlockItem.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves localization off of mixins and onto ordinary TranslatableTexts supplied by the BlockItem subclass. Should produce identical results for both current and legacy translation keys.
Allows localization overrides (see Create uk_ua.json #42) - for example,
block.architecture_extensions.minecraft.stone_archfor the blockarchitecture_extensions:minecraft/stone_archAdds meta-blocktype selectors in the staticdata schema. Allows people to future-proof by specifying
#stoneas a blockType instead of copying in every type stone blocks use.Adds a 'creative' recipeConfigurator that will result in no recipes being generated.
Adds renderLayer to GroupedBlock, and
render_layerkey to the static-data schema, so you can use translucent base blocks