Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ReactantExtra to "lib/" #265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move ReactantExtra to "lib/" #265

wants to merge 1 commit into from

Conversation

mofeing
Copy link
Collaborator

@mofeing mofeing commented Nov 12, 2024

No description provided.

@wsmoses
Copy link
Member

wsmoses commented Nov 12, 2024

Reactant currently places the jll code in the standard place in julia libraries: https://github.com/maleadt/LLVM.jl/tree/master/deps
https://github.com/EnzymeAD/Enzyme.jl/tree/main/deps

@avik-pal
Copy link
Collaborator

We should keep the directory as is but rename build_local.jl to build.jl, then Pkg.build will work

(Reactant) pkg> ?build 
  build [-v|--verbose] pkg[=uuid] ...

  Run the build script in deps/build.jl for pkg and all of its dependencies in depth-first recursive order. If no packages are given, run the build scripts for all packages in the manifest. The -v/--verbose option redirects build output to stdout/stderr instead of the build.log file. The startup.jl file is disabled
  during building unless julia is started with --startup-file=yes.

@wsmoses
Copy link
Member

wsmoses commented Nov 12, 2024

I will cc @vchuravy and @maleadt here since both LLVM.jl and Enzyme.jl call it build_local.jl and I don't have more context/reasoning why

@mofeing
Copy link
Collaborator Author

mofeing commented Nov 12, 2024

We should keep the directory as is but rename build_local.jl to build.jl, then Pkg.build will work

nope, that would trigger full compilation of ReactantExtra by any user that installs Reactant. the build step is automatically run the first time the package is installed on a env. check https://pkgdocs.julialang.org/v1/creating-packages/#Adding-a-build-step-to-the-package

Reactant currently places the jll code in the standard place in julia libraries: maleadt/LLVM.jl@master/deps
EnzymeAD/Enzyme.jl@main/deps

aha, i see. then I will refactor this PR to just some cleaning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants