Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ReactantExtra to "lib/" #265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,16 +89,16 @@ jobs:
id: build_libreactant
run: |
python -m pip install numpy
julia --color=yes --project=deps -e 'using Pkg; Pkg.instantiate()'
julia --color=yes --project=deps deps/build_local.jl
julia --color=yes --project=lib/ReactantExtra -e 'using Pkg; Pkg.instantiate()'
julia --color=yes --project=lib/ReactantExtra lib/ReactantExtra/build_local.jl
cp LocalPreferences.toml test/
- name: Build libReactant MacOS
if: ${{ matrix.libReactant == 'local' && matrix.os == 'macOS-latest'}}
id: build_libreactant_mac
run: |
python -m pip install numpy
julia --color=yes --project=deps -e 'using Pkg; Pkg.instantiate()'
SDKROOT=`xcrun --show-sdk-path` julia --color=yes --project=deps deps/build_local.jl
julia --color=yes --project=lib/ReactantExtra -e 'using Pkg; Pkg.instantiate()'
SDKROOT=`xcrun --show-sdk-path` julia --color=yes --project=lib/ReactantExtra lib/ReactantExtra/build_local.jl
cp LocalPreferences.toml test/
- name: "Install Dependencies and Run Tests"
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/regenerate-mlir-bindings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ jobs:
Pkg.precompile()
using Clang
Clang.JLLEnvs.get_system_includes()
working-directory: ./deps/ReactantExtra
working-directory: ./lib/ReactantExtra
env:
JULIA_DEPOT_PATH: ${{ runner.temp }}/julia_depot
- name: Generate MLIR Bindings
run: julia --project=. --color=yes make-bindings.jl
working-directory: ./deps/ReactantExtra
working-directory: ./lib/ReactantExtra
env:
JULIA_DEPOT_PATH: ${{ runner.temp }}/julia_depot
- run: |
Expand Down
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,8 @@ Manifest.toml
# Built Visual Studio Code Extensions
*.vsix

deps/ReactantExtra/bazel-*
deps/ReactantExtra/MODULE.bazel.lock
lib/ReactantExtra/bazel-*
lib/ReactantExtra/MODULE.bazel.lock
*.swp
*.swo
external
Expand Down
6 changes: 0 additions & 6 deletions deps/ReactantExtra/Project.toml

This file was deleted.

2 changes: 0 additions & 2 deletions deps/clang

This file was deleted.

2 changes: 0 additions & 2 deletions deps/clang++

This file was deleted.

3 changes: 0 additions & 3 deletions deps/gcc

This file was deleted.

File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 0 additions & 2 deletions deps/ReactantExtra/BUILD → lib/ReactantExtra/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,6 @@ cc_toolchain_config(
target_system_name = "x86_64-unknown-linux-gnu",
tool_paths = {
"/usr/bin/gcc": "/home/wmoses/llvms/llvm16/install/bin/clang",
# "/usr/bin/gcc": "/home/wmoses/git/Reactant.jl/deps/clang",
# "gcc": "/home/wmoses/git/Reactant.jl/deps/clang",
"gcc": "/home/wmoses/llvms/llvm16/install/bin/clang",
"g++": "/home/wmoses/llvms/llvm16/install/bin/clang++",
"cpp": "/home/wmoses/llvms/llvm16/install/bin/clang++",
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion deps/build_local.jl → lib/ReactantExtra/build_local.jl
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Invoke with
# `julia --project=deps deps/build_local.jl [dbg/opt] [auto/cpu/cuda]`
# `julia --project=lib/ReactantExtra lib/ReactantExtra/build_local.jl [dbg/opt] [auto/cpu/cuda]`

# the pre-built ReactantExtra_jll might not be loadable on this platform
Reactant_jll = Base.UUID("0192cb87-2b54-54ad-80e0-3be72ad8a3c0")
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Loading