Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alert] Make placement of link slot consistent with Notice #5254

Closed
Tracked by #5665
macandcheese opened this issue Sep 1, 2022 · 3 comments
Closed
Tracked by #5665

[Alert] Make placement of link slot consistent with Notice #5254

macandcheese opened this issue Sep 1, 2022 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request.
Milestone
2023 January Prio...

Comments

@macandcheese
Copy link
Contributor

Description

Currently, the alert's slotted link content is placed in a trailing position adjacent to slotted message content. We should style and position this to match the notice component, where it is consistently placed beneath slotted message or title content.

Acceptance Criteria

The notice and alert slot have the same placement and styling for slotted link content.

Relevant Info

If a user wants to retain the slotted link's position as it currently displays, they can just slot a link alongside other message text. cc @ashetland

Which Component

Alert / Notice

Example Use Case

No response
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 1, 2022
@ashetland ashetland self-assigned this Oct 13, 2022
@ashetland ashetland added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 13, 2022
@ashetland
Copy link
Contributor

Design complete in Figma. Updated design also addresses issues #3338 and #2382. cc: @geospatialem

This was referenced Oct 28, 2022
Closed
Closed
@geospatialem geospatialem mentioned this issue Oct 28, 2022
Closed
5 tasks
@geospatialem geospatialem added 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 28, 2022
@geospatialem geospatialem added this to the 2023 January Priorities milestone Nov 23, 2022
@Elijbet Elijbet self-assigned this Nov 29, 2022
@Elijbet Elijbet mentioned this issue Nov 30, 2022
Merged
Elijbet added a commit that referenced this issue Dec 1, 2022
@Elijbet
fix(alert): placement of link consistent with notice (#5852)
56e35ab 
**Related Issue:** #5254

## Summary

The `notice` and `alert` slots have the same placement and styling for
the slotted `link` content.
@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Dec 1, 2022
@github-actions github-actions bot assigned benelan and geospatialem and unassigned Elijbet Dec 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Installed and assigned for verification.

@benelan benelan removed their assignment Dec 8, 2022
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 8, 2022
@geospatialem
Copy link
Member

Verified on next.662

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request.
Projects
None yet
Milestone
2023 January Priorities
Development

No branches or pull requests
5 participants
@macandcheese @geospatialem @benelan @Elijbet @ashetland