Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text-area): make readOnly prop writable #11218

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix(text-area): make readOnly prop writable #11218

merged 1 commit into from
Jan 7, 2025

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 7, 2025 •
edited
Loading

Related Issue: #11217 #10731

Summary

Removes unintentional @readonly on readOnly prop.

For context, with #10310 any props with the @readonly tag will be made read-only.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 7, 2025
@jcfranco jcfranco added no changelog entry Use the commit override to avoid a changelog entry skip visual snapshots Pull requests that do not need visual regression testing. labels Jan 7, 2025
driskull
driskull approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit 0cbf766 into dev Jan 7, 2025
21 of 22 checks passed
@jcfranco jcfranco deleted the jcfranco/11217-remove-unnecessary-readonly-tags branch January 7, 2025 20:14
benelan pushed a commit that referenced this pull request Feb 8, 2025
@jcfranco @benelan
fix(text-area): make readOnly prop writable (#11218)
cef861e 
**Related Issue:** #11217 #10731

## Summary

Removes unintentional `@readonly` on `readOnly` prop. 

For context, with #10310 any props with the `@readonly` tag will be made
read-only.
@calcite-admin calcite-admin mentioned this pull request Feb 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@anveshmekala anveshmekala Awaiting requested review from anveshmekala

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. no changelog entry Use the commit override to avoid a changelog entry skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2025-02-06 - 3.0.0 Feb Breaking Chang...
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @driskull