-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tab-nav): adds optional closable functionality to individual tab-titles
#6740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the next tab after the current selected tab is closed (next tab is now at the same index position)
…ivated when selected, as selected is no longer always activated, replace with isTrusted.
**Related Issue:** N/A ## Summary ✨🧹✨
**Related Issue:** #N/A ## Summary This PR will add t9n message bundles for the following components: - calcite-card - calcite-combobox - calcite-handle (updates) - calcite-input-date-picker - calcite-input-time-picker - calcite-input-time-zone - calcite-list-item (updates) - calcite-menu-item - calcite-menu --------- Co-authored-by: jona7150 <[email protected]>
**Related Issue:** n/a ## Summary Adds in the latest Calcite UI icons, `3.22.6` for this week's `1.4.0` release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Issues tied to a new feature or request.
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #2620
Summary
handleTabTitleClose
sequence is as follows:closed
propertyclosable
propertycalciteInternalTabsClose
eventcalciteTabsClose
eventClose
text.handleTabTitleClose
keeps track ofvisibleTabTitlesIndices
instead of having Dom queries filter outhidden
. This helps to synctabs
withtab-titles
using their correspondingid
s set on the original render.visibleTabIndeces
is an array ofid
s of the non-hiddentab-titles
. Whentab-title
isclosed
thisid
is used to navigate to the next visible item. This makes figuring out what the next item should be when closing out of order is now more straightforward.Tests coverage for