-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tab-nav): adds optional closable functionality to individual tab-titles
#6740
Merged
Merged
Changes from 49 commits
Commits
Show all changes
104 commits
Select commit
Hold shift + click to select a range
bce01a7
feat(tab-title): adds optional closable functionality to individual t…
Elijbet 2fb821d
WIP: disableLastClosableTabTitle
Elijbet 715c969
WIP: closingSelectedSequence handles resetting selected attribute on …
Elijbet 3dfb00f
WIP: The last selected tab falls back to the previous when closed.
Elijbet 247bed0
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet a76e456
WIP: clean up logic
Elijbet 0b36ef8
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet e1db7a5
WIP: style changes to accomodate close button
Elijbet 802c673
WIP: modify tests to account for new changes
Elijbet ec9eabc
WIP: describe closing behavior e2e tests
Elijbet a0475c7
Temporary demo for testing
Elijbet a9144b3
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet e642813
WIP: work out the css
Elijbet 35e921f
WIP: bring back border styling
Elijbet 95072c5
WIP: render last remaining styles as disabled
Elijbet 6114d2b
WIP: use hidden instead of removing the element
Elijbet 6b942ba
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet 7d33b18
WIP: remove observer and list prop and adjust tabTitles instead
Elijbet 5e9a9d8
fix for eliza
driskull 90898a5
WIP: remove existing logic for emitting emitActiveTab as non-user act…
Elijbet 08b1580
merge conflicts resolved
Elijbet f16b06c
cleanup
Elijbet 821913e
WIP: refactor
Elijbet 0d04d6e
cleanup
Elijbet 8328df9
cleanup
Elijbet 50a7642
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet cf78ae3
cleanup
Elijbet 497d16a
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet bbb9408
WIP: apply forceUpdate to non-selected closable tabs to force selecti…
Elijbet f4de254
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet d51f252
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet 1ab3e27
WIP: refactors
Elijbet caa8e22
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet 91d8b8d
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet 47708d7
WIP: handleTabTitleClose keep track of visibleTabIndeces instead of h…
Elijbet 1ff3f29
cleanup
Elijbet 0d11557
WIP: cleanup
Elijbet 0b002d1
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet 83c6d11
Add test for the closing sequence: works when closing tab-titles in s…
Elijbet 49ffa03
workaround
Elijbet 66fb3c1
Refactor closing sequence describe block, add when closing tab-titles…
Elijbet afc262b
refactors and cleanup
Elijbet f2261a0
adjust existing tab-title test for should inherit default medium scal…
Elijbet dcfeeff
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet 4b4a2f2
cleanup
Elijbet 0123c9f
pick up feedback
Elijbet 6904317
css and test adjustments
Elijbet a26e832
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet 74a118b
add closable option to stories for bordered and icons
Elijbet de2bbe0
merge files and cleanup
Elijbet f06f4b0
add coverage for 'closing an unselected tab-title does not deselect t…
Elijbet 6499866
Remove unwanted readme files
Elijbet 0745688
fix to focus styles differenciation for tab and the close button
Elijbet 2ae1549
additional tests for randomized close | selection sequence and cleanup
Elijbet 2a802ca
drop unnecessary event cancelation
jcfranco ab4adf5
tidy up eslint-disabled lines
jcfranco ab2bc58
revert menu t9n manifest entry
jcfranco 1821aa7
add ID to tab event detail interface doc
jcfranco e3b5a41
tidy up tab-title CSS object
jcfranco 6519122
tidy up types
jcfranco 8dfdb64
restore interface prop
jcfranco e46e1b5
fix missed renames
jcfranco 685d69a
tidy up tab-title test
jcfranco 19e9045
restore demo
Elijbet 2dd39bd
fix(input-date-picker): update input-date-picker to properly handle B…
jcfranco 1c2efac
build(deps): Bump focus-trap from 7.4.1 to 7.4.2 (#6974)
driskull 18255f2
chore(release): 1.4.0-next.17
github-actions[bot] cef59db
fix(flow-item): Close back button tooltip on click (#6978)
driskull 6062b73
chore(release): 1.4.0-next.18
github-actions[bot] d7bdd2b
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet 21213b4
refactor loopTabTitles to be a function where you can pass the argume…
Elijbet 30fa462
add missing await after setting tab-title attribute in test
jcfranco 51da63d
roll back unnecessary changes
jcfranco b54f6e5
tidy up
jcfranco 45b547c
tidy up
jcfranco 25c3579
tweak close button listeners
jcfranco 1221b16
tweak close button props
jcfranco 0c6c3a0
refactor to check for property instead of the attribute
Elijbet d0c301c
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet ab9fb0c
refactor to simplify handleTabTitleClose, restore withIcons story, cl…
Elijbet 92863e8
cleanup
Elijbet b4326d9
restored bordered story and add one for closable separately
Elijbet ec06997
pick up feedback
Elijbet 0724469
prefixed ids with title1-/tab1- numbering for ease of tracking
Elijbet 57d00f7
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet 1015717
tidy up
jcfranco d6335fe
use close button click events for Space/Enter
jcfranco d621bee
ensure selected tab is in focus after closing
jcfranco e623704
tweak styles
jcfranco 4674739
fix selected bordered tab-title regression
jcfranco 0d09592
restore styles and tidy up
jcfranco 6fd6293
tweak styles
jcfranco 0bde7c4
ensure tab indicator is rendered on top
jcfranco a059aed
fix x-button placement
jcfranco ed23b01
fix test
jcfranco 536bb41
drop name in the id in favor of numbering
Elijbet bd0fcdb
chore(release): 1.4.0-next.23
github-actions[bot] 563fa37
refactor(combobox, combobox-item): tidy up CSS object usage (#6979)
jcfranco 692677f
chore: add t9n message bundles. (#6955)
anveshmekala 955e785
build(deps): bump calcite-ui-icons to 3.22.6 (#6984)
geospatialem 67ba5ed
fix(popover): change event listener to 'pointerup' (#6985)
driskull d2f2a4b
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet af81378
add bordered boolean knob to the closable story
Elijbet edce0da
Merge branch 'master' into elijbet/2620-closable-tabs
Elijbet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Close" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_ar.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "إغلاق" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_bg.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Затваряне" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_bs.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Zatvori" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_ca.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Tanca" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_cs.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Zavřít" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_da.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Luk" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_de.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Schließen" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_el.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Κλείσιμο" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_en.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Close" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_es.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Cerrar" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_et.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Sule" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_fi.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Sulje" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_fr.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Fermer" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_he.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "סגירה" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_hr.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Zatvori" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_hu.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Bezárás" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_id.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Tutup" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_it.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Chiudi" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_ja.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "閉じる" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_ko.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "닫기" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_lt.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Uždaryti" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_lv.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Aizvērt" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_nl.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Sluiten" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_no.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Lukk" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_pl.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Zamknij" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_pt-BR.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Fechar" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_pt-PT.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Fechar" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_ro.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Închidere" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_ru.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Закрыть" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_sk.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Zatvoriť" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_sl.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Zapri" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_sr.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Zatvori" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_sv.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Stäng" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_th.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "ปิด" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_tr.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Kapat" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_uk.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Закрити" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_vi.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "Đóng" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_zh-CN.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "关闭" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_zh-HK.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "關閉" | ||
} |
3 changes: 3 additions & 0 deletions
3
src/components/tab-title/assets/tab-title/t9n/messages_zh-TW.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"close": "關閉" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,15 @@ | ||
export const CSS = { | ||
close: "tab-title-close", | ||
closeButton: "close-button", | ||
container: "container", | ||
containerHasText: "container--has-text", | ||
content: "content", | ||
contentHasText: "content--has-text", | ||
iconEnd: "icon-end", | ||
iconStart: "icon-start", | ||
iconPresent: "icon-present", | ||
titleIcon: "calcite-tab-title--icon" | ||
}; | ||
|
||
export const ICONS = { | ||
close: "x" | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of calling forceUpdate, is there an internal prop that could be added on the element or something in order to more naturally trigger a rerender?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fails to update
tabs
in a few places whentabTitle
changes due to the selection moving aftertab-title
closes. I'll be following this up with a refactor issue on all tab-related components, as they are a bit more complicated than might need to be. And to address inconsistent variable naming. I'll addforceUpdate
as an item to address.