Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦️ Package correlations #7

Merged
merged 6 commits into from
Jun 24, 2024
Merged

📦️ Package correlations #7

merged 6 commits into from
Jun 24, 2024

Conversation

shnizzedy
Copy link
Member

@shnizzedy shnizzedy commented Nov 14, 2023

Fixes

calculate_correlations.py in amygutierrez/regression_dashboard and cpac_correlations.py in this repo were the same file with recent parallel modifications.

Description

This PR

  1. merges those changes back into a single source of truth (in this repo, to be imported in the other repo)
  2. moves the script into its own module with packaging info for ease of use elsewhere
  3. cherry-picks the pre-commit hooks from C-PAC

Technical details

The GitHub diff on the PR is showing deleted & new files for the moved path, but you can see the diff from the merge here + here

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the main branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy
Copy link
Member Author

shnizzedy commented Nov 14, 2023

I'm marking [marked] this as a draft, blocked by sgiavasis#4 because I want[ed] those changes reflected here and I'll backmerge[d] them here before (/ if) we merge this one

shnizzedy added a commit to shnizzedy/dashboard that referenced this pull request Nov 14, 2023
@shnizzedy shnizzedy force-pushed the package_correlations branch 5 times, most recently from 49971b8 to 3affc5c Compare November 15, 2023 02:48
@shnizzedy shnizzedy marked this pull request as ready for review December 13, 2023 22:54
@shnizzedy shnizzedy requested a review from a team December 13, 2023 22:55
Copy link

@sgiavasis sgiavasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@shnizzedy shnizzedy merged commit cec2325 into main Jun 24, 2024
@shnizzedy shnizzedy deleted the package_correlations branch June 24, 2024 17:02
shnizzedy added a commit to shnizzedy/dashboard that referenced this pull request Jun 24, 2024
shnizzedy added a commit to shnizzedy/dashboard that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants