Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes in cpac_correlations #4

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

e-kenneally
Copy link

  1. Changed deprecated np.float --> float
  2. Changed deprecated get_data() --> get_fdata()
  3. Removed 'keepDims' parameter, since that was creating the nested arrays, such as array([[[[1.]]]]. The nested arrays prevented boxplot generation.

@shnizzedy
Copy link
Collaborator

shnizzedy commented Nov 14, 2023

There's even more parallel development than I realized in this repo (and its forks, and other repos). This PR's based on FCP-INDI@main but is targeting sgiavasis@master
https://github.com/FCP-INDI/CPAC_regtest_pack/network so the diff is huge since those branches diverge way back in November 2021.

We probably do want to merge them at some point and decide which is canonical, but I think here we just want to change the PR target to FCP-INDI/main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants