Add support for NET Standard support via new Microsoft.Azure.ServiceBus client #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y version to 1.0.0 from 0.0.7 preview
…oreapp, and added few new options to the azuremessagebusoptions.
…e user does not provide any subscription name then by default guid is generated and topic is used with fanout mode
… library. putting the comment for the github issue.
…onasync, completeasync on different objects bases on the push or pull strategy.
…exception. We instead call the overloaded method with no timeout in that case.
-Added base project for benchmark. Still need to write code. -Removed the files from the Sample project.
- Using Microsoft.Extensions.Logging for logging - Fixed unit test for service message bus
updated service bus with new microsoft.azure.servicebus dotnet library
|
|
|
@shahbarkha I think we just need to resolve all conflicts and use your version completely ignoring master |
|
I'm leaving this open as this fixed several tests as well as logging improvements that we need to bring into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @shahbarkha for her awesome work on the client! Please use the nightly builds from myget & nuget.. These builds should be considered stable but we have decided against pushing them live until a future date. Our reason for doing so is we are not happy with Microsoft's new Management libraries which require you to put Azure AD credentials into your app to use the service bus. They have heard the community loud and clear and are working towards a rewrite (v2) of the management API that uses connection string management like the legacy client.