Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NET Standard support via new Microsoft.Azure.ServiceBus client #2

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Add support for NET Standard support via new Microsoft.Azure.ServiceBus client #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
30248d8
first cut for microsoft.azure.servicebus with new management
shahbarkha Aug 5, 2017
2c2da32
some conditional checks
shahbarkha Aug 7, 2017
553f70e
added sample app for topic and queue and revised the new azure librar…
shahbarkha Aug 14, 2017
3d7599a
removed obsolete constructors
shahbarkha Aug 14, 2017
742f101
added tokencredentials in the library, changed sample project to netc…
shahbarkha Aug 17, 2017
aba238b
Missed out on using the subscription name as a member variable. If th…
shahbarkha Aug 17, 2017
953d01d
some options of SBSubscritpiton will be added in the later release of…
shahbarkha Aug 18, 2017
6b9d889
Fixed few issues found during testing for queues and topic. Enhanced …
shahbarkha Aug 20, 2017
e0c5c0d
corrected the logic to delete the queue
shahbarkha Aug 21, 2017
3c452d0
upgraded assemblies to use dotnetcore2.0
shahbarkha Aug 23, 2017
adc8e6a
fixed bug found during unit test of CanHandleErrorInWorkerAsync method.
shahbarkha Aug 24, 2017
6e2725c
made some changes in the queue implementation to handle calling aband…
shahbarkha Sep 3, 2017
adf4aa6
if Timespan.zero is passed in ReceiveAsync then Azure library throws …
shahbarkha Sep 7, 2017
3d89644
Updated ASB library with 2.0, made sure all the unit tests pass for t…
shahbarkha Oct 24, 2017
799bd97
nugetpackage update
shahbarkha Oct 24, 2017
374487a
Correctly handled AutoComplete feature in the StartWorkingAsync imple…
shahbarkha Oct 29, 2017
d26f0e4
- Updated Foundation to 5.1.1562
shahbarkha Oct 31, 2017
b5d31e1
fixed Dispose method for both the message bus and message queue
shahbarkha Oct 31, 2017
2d37b3a
-updated foundatio to 6.0.1557-pre
shahbarkha Nov 7, 2017
003238f
fixed some logging formatters as suggested by Blake
shahbarkha Nov 8, 2017
4321d14
removed package source from the appveyor.yml
shahbarkha Nov 9, 2017
fa28eab
Merge pull request #1 from shahbarkha/master
niemyjski Nov 14, 2017
702d9a1
Adding retry logic on Createupdate method for the subscription and to…
shahbarkha Nov 15, 2017
f70ab68
minor correction in logging
shahbarkha Nov 15, 2017
d441d36
Merged in master
niemyjski Nov 30, 2017
cc6877d
bumped version to 6.1
niemyjski Nov 30, 2017
fc8ec66
Merge master into shared branch
niemyjski Sep 7, 2018
b14c48a
WIP Updating to the new message bus client
niemyjski Sep 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion Foundatio.AzureServiceBus.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Foundatio.AzureServiceBus.T
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Foundatio.AzureServiceBus", "src\Foundatio.AzureServiceBus\Foundatio.AzureServiceBus.csproj", "{09FAD3AD-C078-4604-8BD1-CFB387882CF0}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Foundatio.Benchmark", "test\Foundatio.Benchmark\Foundatio.Benchmark.csproj", "{E8979C7E-EA61-42AE-9F99-291240D79D80}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -53,14 +55,27 @@ Global
{09FAD3AD-C078-4604-8BD1-CFB387882CF0}.Release|x64.Build.0 = Release|Any CPU
{09FAD3AD-C078-4604-8BD1-CFB387882CF0}.Release|x86.ActiveCfg = Release|Any CPU
{09FAD3AD-C078-4604-8BD1-CFB387882CF0}.Release|x86.Build.0 = Release|Any CPU
{E8979C7E-EA61-42AE-9F99-291240D79D80}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{E8979C7E-EA61-42AE-9F99-291240D79D80}.Debug|Any CPU.Build.0 = Debug|Any CPU
{E8979C7E-EA61-42AE-9F99-291240D79D80}.Debug|x64.ActiveCfg = Debug|Any CPU
{E8979C7E-EA61-42AE-9F99-291240D79D80}.Debug|x64.Build.0 = Debug|Any CPU
{E8979C7E-EA61-42AE-9F99-291240D79D80}.Debug|x86.ActiveCfg = Debug|Any CPU
{E8979C7E-EA61-42AE-9F99-291240D79D80}.Debug|x86.Build.0 = Debug|Any CPU
{E8979C7E-EA61-42AE-9F99-291240D79D80}.Release|Any CPU.ActiveCfg = Release|Any CPU
{E8979C7E-EA61-42AE-9F99-291240D79D80}.Release|Any CPU.Build.0 = Release|Any CPU
{E8979C7E-EA61-42AE-9F99-291240D79D80}.Release|x64.ActiveCfg = Release|Any CPU
{E8979C7E-EA61-42AE-9F99-291240D79D80}.Release|x64.Build.0 = Release|Any CPU
{E8979C7E-EA61-42AE-9F99-291240D79D80}.Release|x86.ActiveCfg = Release|Any CPU
{E8979C7E-EA61-42AE-9F99-291240D79D80}.Release|x86.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
EndGlobalSection
GlobalSection(NestedProjects) = preSolution
{9832E1F4-C826-4704-890A-00F330BC5913} = {70515E66-DAF8-4D18-8F8F-8A2934171AA9}
{E8979C7E-EA61-42AE-9F99-291240D79D80} = {70515E66-DAF8-4D18-8F8F-8A2934171AA9}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {EE921DAB-798D-423B-91C5-EB749A19EA52}
SolutionGuid = {00477E15-933C-4D1F-A3BB-CFDC5C38A003}
EndGlobalSection
EndGlobal
6 changes: 0 additions & 6 deletions NuGet.Config
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions NuGet.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<configuration>
<packageSources>
<add key="Exceptionless" value="https://www.myget.org/F/exceptionless/api/v3/index.json" />
</packageSources>
</configuration>
2 changes: 1 addition & 1 deletion build/version.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!-- This file may be overwritten by automation. Only values allowed here are VersionPrefix and VersionSuffix. -->
<Project>
<PropertyGroup>
<VersionPrefix>6.0.0</VersionPrefix>
<VersionPrefix>6.1.0</VersionPrefix>
<VersionSuffix>dev</VersionSuffix>
</PropertyGroup>
</Project>
1 change: 1 addition & 0 deletions src/Foundatio.AzureServiceBus/Extensions/TaskExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System.Threading.Tasks;
using Foundatio.AsyncEx;

using Foundatio.AsyncEx;
namespace Foundatio.Extensions {
internal static class TaskExtensions {
[DebuggerStepThrough]
Expand Down
10 changes: 8 additions & 2 deletions src/Foundatio.AzureServiceBus/Foundatio.AzureServiceBus.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
<Project Sdk="Microsoft.NET.Sdk">
<Import Project="..\..\build\common.props" />
<PropertyGroup>
<TargetFrameworks>net462</TargetFrameworks>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<PackageTags>Queue;Messaging;Message;Bus;ServiceBus;Distributed;Azure;broker;NETSTANDARD;Core</PackageTags>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Foundatio" Version="7.0.1738" />
<PackageReference Include="WindowsAzure.ServiceBus" Version="5.0.0" />
<PackageReference Include="Microsoft.Azure.ServiceBus" Version="3.1.0" />
</ItemGroup>
<ItemGroup>
<Folder Include="Properties\" />
</ItemGroup>
<ItemGroup>
<PackageReference Update="SourceLink.Create.GitHub" Version="2.6.0" />
</ItemGroup>
</Project>
197 changes: 128 additions & 69 deletions src/Foundatio.AzureServiceBus/Messaging/AzureServiceBusMessageBus.cs
View file
Open in desktop

Large diffs are not rendered by default.

33 changes: 31 additions & 2 deletions src/Foundatio.AzureServiceBus/Messaging/AzureServiceBusMessageBusOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,20 @@
using System;
using Microsoft.ServiceBus;
using Microsoft.ServiceBus.Messaging;
using Microsoft.Azure.ServiceBus;

namespace Foundatio.Messaging {
public class AzureServiceBusMessageBusOptions : SharedMessageBusOptions {
public string ClientId { get; set; }

public string ClientSecret { get; set; }

public string TenantId { get; set; }

public string SubscriptionId { get; set; }

public string ResourceGroupName { get; set; }

public string NameSpaceName { get; set; }

public string ConnectionString { get; set; }

/// <summary>
Expand All @@ -12,6 +23,11 @@ public class AzureServiceBusMessageBusOptions : SharedMessageBusOptions {
/// </summary>
public int? PrefetchCount { get; set; }

/// <summary>
/// Gets or sets the maximum number of concurrent calls to the callback the message pump should initiate. Default value is 1
/// </summary>
public int? MaxConcurrentCalls { get; set; }

/// <summary>
/// The idle interval after which the topic is automatically deleted. The minimum duration is 5 minutes.
/// </summary>
Expand Down Expand Up @@ -52,6 +68,19 @@ public class AzureServiceBusMessageBusOptions : SharedMessageBusOptions {
/// </summary>
public bool? TopicIsAnonymousAccessible { get; set; }

/// <summary>
/// Gets or sets a value that indicates whether the message-pump should call Complete(Guid) or Complete(Guid) on messages
/// after the callback has completed processing. By default its set to TRUE
/// </summary>
public bool? AutoComplete { get; set; }

/// <summary>
/// There are wo different receive modes in Service Bus. PeekLock is set by default. For Subscription its best to use
/// ReceiveAndDelete with AutoComplete set to true or PeekAndLock with AutoComplete set to true.
/// This way azure message pump will take care of calling completeasync for you.
/// </summary>
public ReceiveMode ReceiveMode { get; set; }

/// <summary>
/// Returns the status of the topic (enabled or disabled). When an entity is disabled, that entity cannot send or receive messages.
/// </summary>
Expand Down
Loading