-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix]作品詳細画面の通信部分を修正 #121
Open
yuuhanasaki39
wants to merge
10
commits into
develop
Choose a base branch
from
fix/work-detail-service
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[fix]作品詳細画面の通信部分を修正 #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M0710Fa
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
いいと思います!正常に動作することを確認しました!!
prの#106と被っている部分があるのでマージのときは @yuhei-yama と相談してください!
また,gradle.propertiesの件とRepository層でtokenを渡す旨も雄平に共有お願いします!!
This was referenced Nov 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応するissue
関連PR
概要
やってないこと
意図する動作内容(または変更点)
app/gradle.propertiesにkeyを設定すると詳細画面でデータをとってくるようになる
[リファクタ] WorkRepository, WorkDetailViewModelあたり関連箇所
スクリーンショット(UI作成,変更時)
その他
サーバーIP、ポート、トークンをapp/gradle.propertiesに切り出して参照できるよう変更しました。
各自でappモジュール直下にgradle.propertiesを作り以下のコードを設定してください。
app/gradle.properties
該当変更箇所