Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]compile-sdkを33にあげた #135

Merged
merged 1 commit into from
Dec 18, 2023
Merged

[Fix]compile-sdkを33にあげた #135

merged 1 commit into from
Dec 18, 2023

Conversation

yuuhanasaki39
Copy link
Contributor

@yuuhanasaki39 yuuhanasaki39 commented Nov 13, 2023 •
edited
Loading

概要

関連PR

  1. CompileSDKを上げる　← いまここ
  2. Compose導入とRecyclerViewの置き換え
  3. データクラスの変更
  4. 作品詳細画面の修正

意図する動作内容（または変更点）

  • ビルドできること

スクリーンショット（UI作成，変更時）

その他

@yuuhanasaki39 yuuhanasaki39 self-assigned this Nov 13, 2023
@yuuhanasaki39 yuuhanasaki39 changed the title compile-sdkを33にあげた [Fix]compile-sdkを33にあげた Nov 13, 2023
This was referenced Nov 13, 2023
Merged
Open
yuhei-yama
yuhei-yama approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@yuhei-yama yuhei-yama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ローカル環境での動作確認しました！
Buildも問題なく通ることも確認できました！

@yuuhanasaki39 yuuhanasaki39 merged commit 898b4d5 into develop Dec 18, 2023
1 check passed
@yuuhanasaki39 yuuhanasaki39 deleted the fix/upgrade-compile-sdk branch December 18, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhei-yama yuhei-yama yuhei-yama approved these changes

Assignees

@yuuhanasaki39 yuuhanasaki39

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuuhanasaki39 @yuhei-yama