Fix player skin fetching method in AbstractClientPlayer #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eigenraven
approved these changes
Aug 30, 2023
DrParadox7
added a commit
to DrParadox7/Hodgepodge
that referenced
this pull request
Oct 27, 2023
Allow getDownloadImageSkin() fixes (such as GTNewHorizons#237) to apply to Witchery's Mirror content (demon reflections, player camouflage and sleeping bodies). This wasn't fixed before due to Witchery's decision to copy and paste that vanilla class rather than reference it.
DrParadox7
added a commit
to DrParadox7/Hodgepodge
that referenced
this pull request
Oct 28, 2023
Allow getDownloadImageSkin() fixes (such as GTNewHorizons#237) to apply to Witchery's Mirror content (demon reflections, player camouflage and sleeping bodies). This wasn't fixed before due to Witchery's decision to copy and paste that vanilla class rather than reference it.
mitchej123
pushed a commit
that referenced
this pull request
Oct 28, 2023
Allow getDownloadImageSkin() fixes (such as #237) to apply to Witchery's Mirror content (demon reflections, player camouflage and sleeping bodies). This wasn't fixed before due to Witchery's decision to copy and paste that vanilla class rather than reference it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractClientPlayer#getDownloadImageSkindepends on the now-defunct skins.minecraft.net, breaking skin loading for (at least) FTBU and BQ.This redirects it to a working public api that can accept usernames. Should this be changed to use a different api setup (currently it is not the fastest, due to performing uuid lookup), or is this good enough?