netcdf-{c,fortran}: run tests on run_tests, not run_after(install) #526
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
approved these changes
Mar 7, 2025
|
This fell through the cracks. Is this still relevant and ready to go? |
AlexanderRichert-NOAA
merged commit 5967889
into
JCSDA:spack-stack-dev
15 checks passed
|
Yep, thanks |
|
We'll need a submodule pointer update in spack-stack for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the netcdf-c and netcdf-fortran test run conditions by checking
run_testsin addition to@run_after("install")(which is still needed in order to have the test output get logged). It nullifies thecheck()function to prevent duplicate tests. I have confirmed on my personal machine that the tests only run with 'spack install --test'. These changes can be reverted or made nicer once spack#49200 is resolved.