Add option to make verbose = true
apply recursively to nested test sets
#57084
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted a feature where
verbose = true
would apply to nested test sets all the way down the nesting, so I made it. Any interest in having this as part ofDefaultTestSet
? I didn't discuss this with anyone before hand, so "we don't want this, please close" is a valid response.I wasn't sure about the best interface. I went with
verbose = 2
, but happy to consider e.g.verbose = :recursive
. Currentlyverbose = 1
is equivalent toverbose = true
.I'm leaving this as a draft because it currently breaks the
DefaultTestSet
constructors: If someone uses the "full" inner constructor with aBool
forverbose
it'll error.DefaultTestSet
isn't exported, but I would still like to fix that. I'll pause here to get comments though before implementing the fix.