Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to make verbose = true apply recursively to nested test sets #57084

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mhauru
Copy link
Contributor

@mhauru mhauru commented Jan 17, 2025

I wanted a feature where verbose = true would apply to nested test sets all the way down the nesting, so I made it. Any interest in having this as part of DefaultTestSet? I didn't discuss this with anyone before hand, so "we don't want this, please close" is a valid response.

I wasn't sure about the best interface. I went with verbose = 2, but happy to consider e.g. verbose = :recursive. Currently verbose = 1 is equivalent to verbose = true.

I'm leaving this as a draft because it currently breaks the DefaultTestSet constructors: If someone uses the "full" inner constructor with a Bool for verbose it'll error. DefaultTestSet isn't exported, but I would still like to fix that. I'll pause here to get comments though before implementing the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant