generated from quinnj/Example.jl
-
Notifications
You must be signed in to change notification settings - Fork 9
Replace LoggingExtras.jl dep with our own debug macro #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nickrobinson251
merged 4 commits into
npr-log-when-all-tests-done
from
npr-drop-loggingextrasjl
Jan 9, 2025
Merged
Replace LoggingExtras.jl dep with our own debug macro #195
nickrobinson251
merged 4 commits into
npr-log-when-all-tests-done
from
npr-drop-loggingextrasjl
Jan 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
reviewed
Oct 22, 2024
Merged
NHDaly
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
And welcome back from your time off! :) |
nickrobinson251
added a commit
that referenced
this pull request
Apr 6, 2025
* Replace LoggingExtras.jl dep with our own debug macro * Update debug log syntax in tests * fixup! Replace LoggingExtras.jl dep with our own debug macro * fixup! Replace LoggingExtras.jl dep with our own debug macro
nickrobinson251
added a commit
that referenced
this pull request
Apr 6, 2025
* Print completion message when all tests are done * More debug logs * Log a message when each worker has completed tests * Fix import for `at-debugv` * Debug log after `close(worker)` * Use at-debug in workers.jl * Add worker num to all worker restart messages * Fix typo in debug message * Make worker debug messages consistent * Replace LoggingExtras.jl dep with our own debug macro (#195) * Replace LoggingExtras.jl dep with our own debug macro * Update debug log syntax in tests * fixup! Replace LoggingExtras.jl dep with our own debug macro * fixup! Replace LoggingExtras.jl dep with our own debug macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #135 (also fix this breakage #197 (comment))