Skip to content

Replace LoggingExtras.jl dep with our own debug macro #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nickrobinson251
Copy link
Collaborator

@nickrobinson251 nickrobinson251 commented Oct 22, 2024

close #135 (also fix this breakage #197 (comment))

@nickrobinson251 nickrobinson251 changed the title WIP: Replace LoggingExtras.jl dep with our own debug macro Replace LoggingExtras.jl dep with our own debug macro Jan 9, 2025
@nickrobinson251 nickrobinson251 marked this pull request as ready for review January 9, 2025 10:38
Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NHDaly
Copy link
Member

NHDaly commented Jan 9, 2025

And welcome back from your time off! :)

@nickrobinson251 nickrobinson251 merged commit 64b1a6c into npr-log-when-all-tests-done Jan 9, 2025
7 checks passed
@nickrobinson251 nickrobinson251 deleted the npr-drop-loggingextrasjl branch January 9, 2025 23:41
nickrobinson251 added a commit that referenced this pull request Apr 6, 2025
* Replace LoggingExtras.jl dep with our own debug macro

* Update debug log syntax in tests

* fixup! Replace LoggingExtras.jl dep with our own debug macro

* fixup! Replace LoggingExtras.jl dep with our own debug macro
nickrobinson251 added a commit that referenced this pull request Apr 6, 2025
* Print completion message when all tests are done

* More debug logs

* Log a message when each worker has completed tests

* Fix import for `at-debugv`

* Debug log after `close(worker)`

* Use at-debug in workers.jl

* Add worker num to all worker restart messages

* Fix typo in debug message

* Make worker debug messages consistent

* Replace LoggingExtras.jl dep with our own debug macro (#195)

* Replace LoggingExtras.jl dep with our own debug macro

* Update debug log syntax in tests

* fixup! Replace LoggingExtras.jl dep with our own debug macro

* fixup! Replace LoggingExtras.jl dep with our own debug macro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants