fix windows failure #197
Open
fix windows failure #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes a windows failure due to asserting Int64 when the architecture may be Int32
```
ERROR: LoadError: TaskFailedException
nested task error: LoadError: MethodError: Cannot `convert` an object of type
Base.RefValue{Int32} to an object of type
Base.RefValue{Int64}
Closest candidates are:
convert(::Type{T}, ::T) where T
@ Base Base.jl:84
Base.RefValue{T}(::Any) where T
@ Base refvalue.jl:8
Stacktrace:
[1] TestItem(number::Base.RefValue{Int32}, name::String, id::String, tags::Vector{Symbol}, default_imports::Bool, setups::Vector{Any}, retries::Int32, timeout::Nothing, skip::Bool, failfast::Nothing, file::String, line::Int32, project_root::String, code::Expr, testsetups::Vector{TestSetup}, workerid::Base.RefValue{Int32}, testsets::Vector{Test.DefaultTestSet}, eval_number::Base.RefValue{Int32}, stats::Vector{ReTestItems.PerfStats}, scheduled_for_evaluation::ReTestItems.ScheduledForEvaluation)
```
|
I'd like to add windows CI to this PR to see if it works there, is that alright? |
auto-merge was automatically disabled
January 8, 2025 23:36
Head branch was pushed to by a user without write access
Yes, but let's only add it for a single Julia version (so we only add a single extra job). |
|
I'm not sure why all the other tests would fail here, but the tests on windows may indicate that some additional work is needed to support windows. |
Look like tests were broken by JuliaLogging/LoggingExtras.jl#94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a windows failure due to asserting Int64 when the architecture may be Int32
fixes #198.