Major cleanup #17
Draft
Major cleanup #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I started to split off some:
While I realize we will likely move away from the tool, I think it still makes sense to clean it up. |
ekohl
force-pushed
the
remove-compat
branch
2 times, most recently
from
036e654
to
6027aa3
Compare
ekohl
force-pushed
the
remove-compat
branch
2 times, most recently
from
a4b1497
to
64dc9a3
Compare
ekohl
force-pushed
the
remove-compat
branch
2 times, most recently
from
f817bfb
to
b422ed0
Compare
This can easily be checked in the function itself without duplicating all the variables.
This was always called twice. It now does the checking as part of the function itself which reduces duplication.
By moving this all into genServerCert, a lot of variable duplication is avoided.
This method allows to fail fast
ekohl
force-pushed
the
remove-compat
branch
from
b422ed0
to
8439c4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove a lot of unused code or rewrite methods to an equivalent but easier implementation. There should be no difference for the end user.
6b4c116 Close file descriptors when possible
5b051f7 Implement katello-ssl-tool via console_scripts
0966426 Simplify value assignment
9f047a7 Drop unique and setIntersection functions
428d38d Remove unused functions
a4be37b Rewrite RPM version comparison code
f082f49 Remove checksum.py by checking file contents