-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major cleanup #17
Draft
ekohl
wants to merge
9
commits into
Katello:master
Choose a base branch
from
ekohl:remove-compat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Major cleanup #17
Commits on Sep 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 12fe6aa - Browse repository at this point
Copy the full SHA 12fe6aaView commit details -
Remove genServerRpm_dependencies
This can easily be checked in the function itself without duplicating all the variables.
Configuration menu - View commit details
-
Copy full SHA for d4d6ab7 - Browse repository at this point
Copy the full SHA d4d6ab7View commit details -
Remove redundant genServerCertReq_dependencies
This was always called twice. It now does the checking as part of the function itself which reduces duplication.
Configuration menu - View commit details
-
Copy full SHA for 3f81c51 - Browse repository at this point
Copy the full SHA 3f81c51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4440389 - Browse repository at this point
Copy the full SHA 4440389View commit details -
Remove redundant genServerCert_dependencies function
By moving this all into genServerCert, a lot of variable duplication is avoided.
Configuration menu - View commit details
-
Copy full SHA for 29dde82 - Browse repository at this point
Copy the full SHA 29dde82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b6bc49 - Browse repository at this point
Copy the full SHA 9b6bc49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2169737 - Browse repository at this point
Copy the full SHA 2169737View commit details -
Introduce genServerCert_dependencies again
This method allows to fail fast
Configuration menu - View commit details
-
Copy full SHA for a1b277f - Browse repository at this point
Copy the full SHA a1b277fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8439c4b - Browse repository at this point
Copy the full SHA 8439c4bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.