Remove pkg-config from Brewfile #7593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should already be installed by GitHub Actions runner image
sakertooth
approved these changes
Nov 23, 2024
|
I don't really like the idea of omitting dependencies that the GitHub Actions runners happen to have preinstalled; I was rather hoping that the Brewfile would serve as a list of all Homebrew dependencies needed to build LMMS on macOS. This means anyone wanting to build LMMS themselves can just install from the file, and we don't have to maintain a separate dependency list on the wiki. It also means we can rely less on what the runner has preinstalled, and would make any hypothetical future CI service migration easier. Could we treat this as temporary, and once Homebrew and GitHub have fixed their migration problems, revert it? |
|
Sure, I can revert this PR after the upstream issues are resolved |
messmerd
added a commit
to messmerd/lmms
that referenced
this pull request
Nov 27, 2024
This reverts commit 72b30b1.
Merged
rubiefawn
pushed a commit
to rubiefawn/lmms
that referenced
this pull request
Nov 28, 2024
* Update pkg-config to pkgconf * Remove pkg-config/pkgconf Should already be installed by GitHub Actions runner image
messmerd
added a commit
that referenced
this pull request
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homebrew and GitHub Actions build images are both in the process of replacing
pkg-configwithpkgconfwhich is causing temporary build issues for us on macOS ARM64. But since the macOS runner images already have this dependency installed, so there is no need for us to install it through the Brewfile. Removing it fixes the builds.