refactor: Remove deprecated function that registers an operator of avsRegistry writer

chainio/clients/avsregistry/writer.go

@@ -108,122 +108,7 @@ func NewWriterFromConfig(
 	), nil
 }
 
-// RegisterOperatorInQuorumWithAVSRegistryCoordinator
-// TODO(samlaf): an operator that is already registered in a quorum can register with another quorum without passing
-// signatures perhaps we should add another sdk function for this purpose, that just takes in a quorumNumber and
-// socket? RegisterOperatorInQuorumWithAVSRegistryCoordinator is used to register a single operator with the AVS's
-// registry coordinator. - operatorEcdsaPrivateKey is the operator's ecdsa private key (used to sign a message to
-// register operator in eigenlayer's delegation manager)
-//   - operatorToAvsRegistrationSigSalt is a random salt used to prevent replay attacks
-//   - operatorToAvsRegistrationSigExpiry is the expiry time of the signature
-//
-// Deprecated: use RegisterOperator instead.
-// We will only keep high-level functionality such as RegisterOperator, and low level functionality
-// such as this function should eventually all be done with bindings directly instead.
-func (w *ChainWriter) RegisterOperatorInQuorumWithAVSRegistryCoordinator(
-	ctx context.Context,
-	// we need to pass the private key explicitly and can't use the signer because registering requires signing a
-	// message which isn't a transaction and the signer can only signs transactions see operatorSignature in
-	// https://github.com/Layr-Labs/eigenlayer-middleware/blob/m2-mainnet/docs/RegistryCoordinator.md#registeroperator
-	// TODO(madhur): check to see if we can make the signer and txmgr more flexible so we can use them (and remote
-	// signers) to sign non txs
-	operatorEcdsaPrivateKey *ecdsa.PrivateKey,
-	operatorToAvsRegistrationSigSalt [32]byte,
-	operatorToAvsRegistrationSigExpiry *big.Int,
-	blsKeyPair *bls.KeyPair,
-	quorumNumbers types.QuorumNums,
-	socket string,
-	waitForReceipt bool,
-) (*gethtypes.Receipt, error) {
-	operatorAddr := crypto.PubkeyToAddress(operatorEcdsaPrivateKey.PublicKey)
-	w.logger.Info(
-		"registering operator with the AVS's registry coordinator",
-		"avs-service-manager",
-		w.serviceManagerAddr,
-		"operator",
-		operatorAddr,
-		"quorumNumbers",
-		quorumNumbers,
-		"socket",
-		socket,
-	)
-	// params to register bls pubkey with bls apk registry
-	g1HashedMsgToSign, err := w.registryCoordinator.PubkeyRegistrationMessageHash(&bind.CallOpts{}, operatorAddr)
-	if err != nil {
-		return nil, err
-	}
-	signedMsg := chainioutils.ConvertToBN254G1Point(
-		blsKeyPair.SignHashedToCurveMessage(chainioutils.ConvertBn254GethToGnark(g1HashedMsgToSign)).G1Point,
-	)
-	G1pubkeyBN254 := chainioutils.ConvertToBN254G1Point(blsKeyPair.GetPubKeyG1())
-	G2pubkeyBN254 := chainioutils.ConvertToBN254G2Point(blsKeyPair.GetPubKeyG2())
-	pubkeyRegParams := regcoord.IBLSApkRegistryPubkeyRegistrationParams{
-		PubkeyRegistrationSignature: signedMsg,
-		PubkeyG1:                    G1pubkeyBN254,
-		PubkeyG2:                    G2pubkeyBN254,
-	}
-
-	// params to register operator in delegation manager's operator-avs mapping
-	msgToSign, err := w.elReader.CalculateOperatorAVSRegistrationDigestHash(
-		ctx,
-		operatorAddr,
-		w.serviceManagerAddr,
-		operatorToAvsRegistrationSigSalt,
-		operatorToAvsRegistrationSigExpiry,
-	)
-	if err != nil {
-		return nil, err
-	}
-	operatorSignature, err := crypto.Sign(msgToSign[:], operatorEcdsaPrivateKey)
-	if err != nil {
-		return nil, err
-	}
-	// the crypto library is low level and deals with 0/1 v values, whereas ethereum expects 27/28, so we add 27
-	// see https://github.com/ethereum/go-ethereum/issues/28757#issuecomment-1874525854
-	// and https://twitter.com/pcaversaccio/status/1671488928262529031
-	operatorSignature[64] += 27
-	operatorSignatureWithSaltAndExpiry := regcoord.ISignatureUtilsSignatureWithSaltAndExpiry{
-		Signature: operatorSignature,
-		Salt:      operatorToAvsRegistrationSigSalt,
-		Expiry:    operatorToAvsRegistrationSigExpiry,
-	}
-
-	noSendTxOpts, err := w.txMgr.GetNoSendTxOpts()
-	if err != nil {
-		return nil, err
-	}
-	// TODO: this call will fail if max number of operators are already registered
-	// in that case, need to call churner to kick out another operator. See eigenDA's node/operator.go implementation
-	tx, err := w.registryCoordinator.RegisterOperator(
-		noSendTxOpts,
-		quorumNumbers.UnderlyingType(),
-		socket,
-		pubkeyRegParams,
-		operatorSignatureWithSaltAndExpiry,
-	)
-	if err != nil {
-		return nil, err
-	}
-	receipt, err := w.txMgr.Send(ctx, tx, waitForReceipt)
-	if err != nil {
-		return nil, errors.New("failed to send tx with err: " + err.Error())
-	}
-	w.logger.Info(
-		"successfully registered operator with AVS registry coordinator",
-		"txHash",
-		receipt.TxHash.String(),
-		"avs-service-manager",
-		w.serviceManagerAddr,
-		"operator",
-		operatorAddr,
-		"quorumNumbers",
-		quorumNumbers,
-	)
-	return receipt, nil
-}
-
-// RegisterOperator is similar to RegisterOperatorInQuorumWithAVSRegistryCoordinator but
-// generates a random salt and expiry for the signature.
+// RegisterOperator is used to register a single operator with the AVS's registry coordinator.
 func (w *ChainWriter) RegisterOperator(
 	ctx context.Context,
 	// we need to pass the private key explicitly and can't use the signer because registering requires signing a