fix: cloudbuild trigger SA roles #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chasers FYI. This was the cause of our canary deploy failure, it is a temp fix. Cloud resource manager has quite a bit of tech debt, it fires off a lot of queries on each In pics, each spike is a sign in. 
|
Ziinc
changed the title
|
Not urgent, can wait until team availability is higher. |
|
@chasers FYI, merged for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
.dev.env.encfile to correct location undercloudbuild/so that makefile script works.This PR also adds in additional roles to the cloud build trigger SA, and updates staging secrets to match in use service account (as it seems like resource manager is removing all iam policies not declared).