Refactor readers v #247
Open
Refactor readers v #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jalew188
reviewed
Nov 20, 2024
jalew188
reviewed
Nov 20, 2024
lucas-diedrich
approved these changes
Nov 20, 2024
jalew188
reviewed
Dec 20, 2024
| def __init__( | ||
| self, | ||
| custom_modification_mapping: Optional[Dict[str, str]], | ||
| reader_yaml: Dict, |
There was a problem hiding this comment.
global yaml or reader specific yaml?
jalew188
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move all modification mapping-related logic to a dedicated class